Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: refine the codes of embeded limit of double read #42818

Merged
merged 5 commits into from
May 16, 2023
Merged

planner: refine the codes of embeded limit of double read #42818

merged 5 commits into from
May 16, 2023

Conversation

winoros
Copy link
Member

@winoros winoros commented Apr 4, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #24636, close #35952, close #43528

Problem Summary:

What is changed and how it works?

We fully disabled the embedded limit for double read before.
But we can actually open it by adding one more extra projection.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 4, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 4, 2023
@hawkingrei
Copy link
Member

/test all

time-and-fate
time-and-fate reviewed Apr 26, 2023
View reviewed changes
planner/core/task.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 26, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 8, 2023
@winoros
Copy link
Member Author

winoros commented May 8, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 8, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 69fe832

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 8, 2023
@winoros
Copy link
Member Author

winoros commented May 10, 2023

/retest

2 similar comments
@hawkingrei
Copy link
Member

/retest

@AilinKid
Copy link
Contributor

/retest

@Defined2014 Defined2014 mentioned this pull request May 16, 2023
Closed
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed status/can-merge Indicates a PR has been approved by a committer. do-not-merge/needs-triage-completed labels May 16, 2023
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label May 16, 2023
@winoros
Copy link
Member Author

winoros commented May 16, 2023

/retest

@winoros
Copy link
Member Author

winoros commented May 16, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f65e236

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4422222 into pingcap:master May 16, 2023
@winoros winoros deleted the reinvent-embeded-limit branch May 16, 2023 14:13
@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #43883.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 16, 2023
@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#42818
7ad38b0 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43884.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 16, 2023
@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#42818
4209d38 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request May 17, 2023
@ti-chi-bot
planner: refine the codes of embeded limit of double read (#42818) (#…
e20734d 
…43883)

ref #24636, close #35952, close #43528
ti-chi-bot bot pushed a commit that referenced this pull request May 17, 2023
@ti-chi-bot
planner: refine the codes of embeded limit of double read (#42818) (#…
dd79f8e 
…43884)

ref #24636, close #35952, close #43528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
6 participants
@winoros @ti-chi-bot @hawkingrei @AilinKid @qw4990 @time-and-fate