Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix wrong task types when calculating cost in some cases #43637

Merged
merged 3 commits into from
May 9, 2023
Merged

planner: fix wrong task types when calculating cost in some cases #43637

merged 3 commits into from
May 9, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented May 9, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #35240

Problem Summary: fix wrong task types when calculating cost in some cases

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 9, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 9, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 9, 2023
qw4990
qw4990 commented May 9, 2023
View reviewed changes
planner/core/casetest/testdata/enforce_mpp_suite_out.json
@@ -165,8 +168,8 @@
"Plan": [
"StreamAgg_27 1.00 49.90 root funcs:count(Column#7)->Column#4",
"└─TableReader_28 1.00 0.00 root data:StreamAgg_11",
" └─StreamAgg_11 1.00 1427024.00 batchCop[tiflash] funcs:count(1)->Column#7",
" └─Selection_26 10.00 1427000.00 batchCop[tiflash] eq(test.t.a, 1)",
" └─StreamAgg_11 1.00 952024.00 batchCop[tiflash] funcs:count(1)->Column#7",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected

@ti-chi-bot ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. and removed do-not-merge/needs-linked-issue labels May 9, 2023
@qw4990 qw4990 changed the title Cost fixup planner: fix wrong task types when calculating cost in some cases May 9, 2023
@qw4990 qw4990 added the sig/planner SIG: Planner label May 9, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 9, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented May 9, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 9, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 18711f2

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented May 9, 2023

/merge

@ti-chi-bot ti-chi-bot bot merged commit a7299d3 into pingcap:master May 9, 2023
@qw4990 qw4990 mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qw4990 @hawkingrei @xuyifangreeneyes