-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/backup_ebs: added flag operator-paused-gc-and-scheduler
.
#43687
br/backup_ebs: added flag operator-paused-gc-and-scheduler
.
#43687
Conversation
Signed-off-by: hillium <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
operator-paused-gc-and-scheduler
.operator-paused-gc-and-scheduler
.
Signed-off-by: hillium <[email protected]>
/retest |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 290d515
|
/retest |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #43559
Problem Summary:
After #43562, we get the ability of pausing GC and schedulers in an external pod. But the backup command still tries to pause them, which is not really effective and will bring the ABA problem. (Say, some of BRs think the state of "no scheduler exists" is the original state of the cluster.)
What is changed and how it works?
This PR added a new hidden flag
--operator-paused-gc-and-scheduler
. Once it set, the client will no longer try to pause scheduler (Should / Is it possible to further check whether they are really paused?) and start backup directly after the pending split done.Check List
Tests
Run command:
br_ebs_backup_mocking_wait_snapshot_duration=800s ~/br-operator backup full --type aws-ebs --skip-aws -u http://upd-1:2379 -s noop://
The schedulers are paused.
Run command:
br_ebs_backup_mocking_wait_snapshot_duration=800s ~/br-operator backup full --type aws-ebs --skip-aws --operator-paused-gc-and-scheduler -u http://upd-1:2379 -s noop://
The schedulers are not paused.
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.