*: Introduce runaway statement in resource group #43843

CabinfeverB · 2023-05-15T12:03:57Z

What problem does this PR solve?

Issue Number: ref #43691

Problem Summary:

What is changed and how it works?

After pingcap/kvproto#1122, replace glog goleak function name

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Cabinfever_B <[email protected]>

ti-chi-bot · 2023-05-15T12:04:00Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

hawkingrei
qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2023-05-15T12:04:01Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Cabinfever_B <[email protected]>

CabinfeverB · 2023-05-23T10:57:47Z

cc @glorv @nolouch @Connor1996

nolouch · 2023-05-24T08:00:43Z

parser/parser_test.go

@@ -3700,6 +3701,16 @@ func TestDDL(t *testing.T) {
 		{"create resource group x ru_per_sec=3000 burstable", true, "CREATE RESOURCE GROUP `x` RU_PER_SEC = 3000 BURSTABLE"},
 		{"create resource group x burstable ru_per_sec=4000", true, "CREATE RESOURCE GROUP `x` BURSTABLE RU_PER_SEC = 4000"},
 		{"create resource group x ru_per_sec=20, priority=LOW, burstable", true, "CREATE RESOURCE GROUP `x` RU_PER_SEC = 20 PRIORITY = LOW BURSTABLE"},
+		{"create resource group x ru_per_sec=1000 QUERY LIMIT EXEC_ELAPSED_IN_SEC '10s' ACTION DRYRUN", true, "CREATE RESOURCE GROUP `x` RU_PER_SEC = 1000 QUERY LIMIT EXEC_ELAPSED_IN_SEC = '10s' ACTION DRYRUN"},


IMO, I would like to make all runaway spec into one option, it looks more layered. example:

create resource group x ru_per_sec=1000 RUNAWAY_QUERY='{ LIMIT_EXEC_ELAPSED_IN_SEC="10s", ACTION=KILL}'

cc @songrijie

Signed-off-by: Cabinfever_B <[email protected]>

CabinfeverB · 2023-05-30T11:39:10Z

/test unit-test

Signed-off-by: Cabinfever_B <[email protected]>

glorv · 2023-05-31T06:05:35Z

parser/ast/ddl.go

@@ -2156,8 +2158,62 @@ func (n *ResourceGroupOption) Restore(ctx *format.RestoreCtx) error {
 			ctx.WriteString(n.StrValue)
 		case ResourceBurstableOpiton:
 			ctx.WriteKeyWord("BURSTABLE")
+		case ResourceGroupRunaway:
+			if len(n.ResourceGroupRunawayOptionList) > 0 {
+				ctx.WritePlain("QUERY_LIMIT=(")


Suggested change

ctx.WritePlain("QUERY_LIMIT=(")

ctx.WriteKeyWord("QUERY_LIMIT")

ctx.WritePlain(" = (")

glorv · 2023-05-31T06:07:30Z

parser/model/model.go

+)
+
+// RunawayWatchValueToName converts the runaway watch value to corresponding name
+func RunawayWatchValueToName(value int32) string {


Suggested change

func RunawayWatchValueToName(value int32) string {

func (t RunawayWatchType) String() string {

glorv · 2023-05-31T06:09:46Z

parser/parser_test.go

@@ -3710,6 +3711,19 @@ func TestDDL(t *testing.T) {
 		{"create resource group x ru_per_sec=3000 burstable", true, "CREATE RESOURCE GROUP `x` RU_PER_SEC = 3000 BURSTABLE"},
 		{"create resource group x burstable ru_per_sec=4000", true, "CREATE RESOURCE GROUP `x` BURSTABLE RU_PER_SEC = 4000"},
 		{"create resource group x ru_per_sec=20, priority=LOW, burstable", true, "CREATE RESOURCE GROUP `x` RU_PER_SEC = 20 PRIORITY = LOW BURSTABLE"},
+		{"create resource group x ru_per_sec=1000 QUERY_LIMIT=(EXEC_ELAPSED_IN_SEC '10s' ACTION DRYRUN)", true, "CREATE RESOURCE GROUP `x` RU_PER_SEC = 1000 QUERY_LIMIT=(EXEC_ELAPSED_IN_SEC = '10s' ACTION DRYRUN)"},


The output format is not consistent with each other, (EXEC_ELAPSED_IN_SEC = '10s' ACTION DRYRUN) should be (EXEC_ELAPSED_IN_SEC = '10s' ACTION = DRYRUN)

Connor1996 · 2023-05-31T06:22:55Z

parser/ast/ddl.go

+			ctx.WriteKeyWord(model.RunawayWatchValueToName(n.IntValue))
+			ctx.WritePlain(" ")
+			ctx.WriteKeyWord("DURATION ")
+			ctx.WritePlain("= ")


should after WATCH instead of DURATION

Signed-off-by: Cabinfever_B <[email protected]>

glorv · 2023-05-31T10:01:31Z

/merge

ti-chi-bot · 2023-05-31T10:01:35Z

This pull request has been accepted and is ready to merge.

Commit hash: 50de0c7

Signed-off-by: Cabinfever_B <[email protected]>

glorv · 2023-05-31T11:16:21Z

/merge

ti-chi-bot · 2023-05-31T11:16:26Z

This pull request has been accepted and is ready to merge.

Commit hash: 6edb215

add resource group run away statement

7fd561b

Signed-off-by: Cabinfever_B <[email protected]>

CabinfeverB added 2 commits May 15, 2023 20:08

merge master

d9d85e6

Signed-off-by: Cabinfever_B <[email protected]>

merge master

ea2546e

Signed-off-by: Cabinfever_B <[email protected]>

ti-chi-bot bot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/needs-linked-issue labels May 15, 2023

CabinfeverB added 3 commits May 16, 2023 14:12

unify int type

e135c5b

Signed-off-by: Cabinfever_B <[email protected]>

add test

378ed64

Signed-off-by: Cabinfever_B <[email protected]>

add test

b620b8d

Signed-off-by: Cabinfever_B <[email protected]>

CabinfeverB mentioned this pull request May 16, 2023

ddl, I_S: support runaway attribute in resource group #43877

Merged

12 tasks

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2023

CabinfeverB added 2 commits May 23, 2023 15:37

merge master

9629c5a

Signed-off-by: Cabinfever_B <[email protected]>

merge master

8841b19

Signed-off-by: Cabinfever_B <[email protected]>

CabinfeverB marked this pull request as ready for review May 23, 2023 07:41

ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 23, 2023

CabinfeverB added 4 commits May 23, 2023 15:58

merge master

36edf90

Signed-off-by: Cabinfever_B <[email protected]>

address comment

b45fe72

Signed-off-by: Cabinfever_B <[email protected]>

address comment

97ba6da

Signed-off-by: Cabinfever_B <[email protected]>

address comment

4022180

Signed-off-by: Cabinfever_B <[email protected]>

CabinfeverB force-pushed the resource_manager/runaway_ruke branch from 734155a to 4022180 Compare May 23, 2023 09:26

address comment

a608efa

Signed-off-by: Cabinfever_B <[email protected]>

nolouch reviewed May 24, 2023

View reviewed changes

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023

update kvproto

a8b5ce6

Signed-off-by: Cabinfever_B <[email protected]>

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023

CabinfeverB added 2 commits May 30, 2023 20:51

ignore goleak for glog

e9bc063

Signed-off-by: Cabinfever_B <[email protected]>

ignore goleak for glog

85bf984

Signed-off-by: Cabinfever_B <[email protected]>

CabinfeverB requested a review from a team as a code owner May 30, 2023 14:47

CabinfeverB added 2 commits May 31, 2023 12:56

ignore goleak for glog

437890d

Signed-off-by: Cabinfever_B <[email protected]>

ignore goleak for glog

aea01dd

Signed-off-by: Cabinfever_B <[email protected]>

CabinfeverB force-pushed the resource_manager/runaway_ruke branch from 5be5068 to aea01dd Compare May 31, 2023 05:03

hawkingrei approved these changes May 31, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2023

qw4990 approved these changes May 31, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2023

glorv reviewed May 31, 2023

View reviewed changes

Connor1996 reviewed May 31, 2023

View reviewed changes

CabinfeverB added 2 commits May 31, 2023 16:36

address comment

9fff67c

Signed-off-by: Cabinfever_B <[email protected]>

address comment

50de0c7

Signed-off-by: Cabinfever_B <[email protected]>

glorv approved these changes May 31, 2023

View reviewed changes

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2023

address comment

6edb215

Signed-off-by: Cabinfever_B <[email protected]>

ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2023

ti-chi-bot bot merged commit 4c83352 into pingcap:master May 31, 2023

D3Hunter mentioned this pull request Aug 29, 2024

*: move XXInfo/Job, etc, out from model pkg in parser to meta #55754

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: Introduce runaway statement in resource group #43843

*: Introduce runaway statement in resource group #43843

CabinfeverB commented May 15, 2023 •

edited

Loading

ti-chi-bot bot commented May 15, 2023 •

edited

Loading

ti-chi-bot bot commented May 15, 2023

CabinfeverB commented May 23, 2023

nolouch May 24, 2023 •

edited

Loading

CabinfeverB commented May 30, 2023

glorv May 31, 2023

glorv May 31, 2023

glorv May 31, 2023

Connor1996 May 31, 2023

glorv commented May 31, 2023

ti-chi-bot bot commented May 31, 2023

glorv commented May 31, 2023

ti-chi-bot bot commented May 31, 2023

	ctx.WritePlain("QUERY_LIMIT=(")
	ctx.WriteKeyWord("QUERY_LIMIT")
	ctx.WritePlain(" = (")

	func RunawayWatchValueToName(value int32) string {
	func (t RunawayWatchType) String() string {

*: Introduce runaway statement in resource group #43843

*: Introduce runaway statement in resource group #43843

Conversation

CabinfeverB commented May 15, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot bot commented May 15, 2023 • edited Loading

ti-chi-bot bot commented May 15, 2023

CabinfeverB commented May 23, 2023

nolouch May 24, 2023 • edited Loading

Choose a reason for hiding this comment

CabinfeverB commented May 30, 2023

glorv May 31, 2023

Choose a reason for hiding this comment

glorv May 31, 2023

Choose a reason for hiding this comment

glorv May 31, 2023

Choose a reason for hiding this comment

Connor1996 May 31, 2023

Choose a reason for hiding this comment

glorv commented May 31, 2023

ti-chi-bot bot commented May 31, 2023

glorv commented May 31, 2023

ti-chi-bot bot commented May 31, 2023

CabinfeverB commented May 15, 2023 •

edited

Loading

ti-chi-bot bot commented May 15, 2023 •

edited

Loading

nolouch May 24, 2023 •

edited

Loading