-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Only warn of subpartitions, still allow first level partitioning (#41207) | tidb-test=pr/2166 #43888
ddl: Only warn of subpartitions, still allow first level partitioning (#41207) | tidb-test=pr/2166 #43888
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
b36eeae
to
207d29c
Compare
/retest |
207d29c
to
79129f6
Compare
ee489af
to
a795b29
Compare
/retest |
/retest |
a795b29
to
290d29c
Compare
This PR also picked #38451. |
/retest |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
290d29c
to
344364a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, mjonss, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@YangKeao should we also update the documentation to reflect this? I.e. change 6.4.0, to 6.1.7/6.4.0, see pingcap/docs#11085 |
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #41207
What problem does this PR solve?
Issue Number: close #41198 , close #41200
Problem Summary:
For LIST partitioning, it did not check if SUBPARTITION was used and just stripped the subpartition part
For RANGE and HASH partitioning it stripped all partitioning and added a warning that such partitioning was not supported.
What is changed and how it works?
Combine the two behaviours:
Strip the subpartitioning from the CREATE TABLE statement and issue a warning.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.