ldap: modify variable name and initialize connection with root_dn and root_pwd (#43824) #43914
+18
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #43824
What problem does this PR solve?
Issue Number: close #43822
Problem Summary:
root_pw
, which is different fromroot_pwd
.What is changed and how it works?
root_pwd
.root_dn
androot_pwd
.The only concern is that the the ACL configuration for anonymous user and
root
could be different.Check List
Tests
I manually tested this patch with okta ldap service, which doesn't support anonymous binding.
Copied from #43822, I also attached the "Alternatives" here:
I have checked the behavior on two different implementations:
Alternatives
I think the first one is apparently better.