Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-go: when meet GetStoreMinResolvedTS error just write in debug log #44413

Merged
merged 5 commits into from
Jun 5, 2023

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Jun 5, 2023

Signed-off-by: husharp [email protected]<!--

Thank you for contributing to TiDB!

PR Title Format:

  1. pkg [, pkg2, pkg3]: what's changed
  2. *: what's changed

-->

What problem does this PR solve?

Issue Number: close #44412

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Jun 5, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and pingyu June 5, 2023 09:53
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 5, 2023
@HuSharp
Copy link
Contributor Author

HuSharp commented Jun 5, 2023

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Jun 5, 2023
Signed-off-by: husharp <[email protected]>
@HuSharp
Copy link
Contributor Author

HuSharp commented Jun 5, 2023

related on tikv/client-go#825

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 5, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 5, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-05 10:03:18.523459194 +0000 UTC m=+256184.796431980: ☑️ agreed by rleungx.
  • 2023-06-05 10:11:21.507281298 +0000 UTC m=+256667.780254093: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 5, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lhy1024, rleungx, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YuJuncen,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 7a1cab9 into pingcap:master Jun 5, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44415.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #44416.

@HuSharp HuSharp deleted the fix_pd_log_warn branch June 12, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noisy min-resolved-ts logs when the PD default configuration is min-resolved-ts-persistence-interval=0
6 participants