Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add more test cases for quick binding #44541

Merged
merged 8 commits into from
Jun 9, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 9, 2023

What problem does this PR solve?

Issue Number: ref #39199

Problem Summary: planner: add more test cases for quick binding

What is changed and how it works?

planner: add more test cases for quick binding

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 qw4990 added the sig/planner SIG: Planner label Jun 9, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 9, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 9, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 9, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 9, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 9, 2023

/merge

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 9, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 9, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xuyifangreeneyes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,xuyifangreeneyes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 9, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-09 04:32:00.202766359 +0000 UTC m=+59134.450688177: ☑️ agreed by hawkingrei.
  • 2023-06-09 04:37:05.536691902 +0000 UTC m=+59439.784613758: ☑️ agreed by xuyifangreeneyes.
  • 2023-06-09 06:39:55.39381902 +0000 UTC m=+66809.641740831: ✖️🔁 reset by qw4990.
  • 2023-06-09 07:47:03.672110593 +0000 UTC m=+70837.920032413: ☑️ agreed by hawkingrei.
  • 2023-06-09 07:49:34.557762063 +0000 UTC m=+70988.805683889: ☑️ agreed by xuyifangreeneyes.

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 9, 2023

/merge

@ti-chi-bot ti-chi-bot bot merged commit f95cd53 into pingcap:master Jun 9, 2023
@qw4990 qw4990 added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jun 14, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44677.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants