Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import into: add disable_tikv_import_mode option #44587

Merged
merged 13 commits into from
Jun 16, 2023
Merged

import into: add disable_tikv_import_mode option #44587

merged 13 commits into from
Jun 16, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Jun 12, 2023

What problem does this PR solve?

Issue Number: ref #42930

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 12, 2023
@GMHDBJD GMHDBJD requested review from D3Hunter and lance6716 and removed request for D3Hunter June 12, 2023 09:04
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 12, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 12, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter
D3Hunter approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but that's wait #44602

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

lgtm, but that's wait #44602

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 14, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 14, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 14, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 14, 2023

/retest

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 14, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 15, 2023

/retest

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 15, 2023

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 15, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 15, 2023

/merge

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 15, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 15, 2023

/retest

@lance6716
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 15, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 15, 2023
@GMHDBJD GMHDBJD removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 15, 2023

/merge

@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 15, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 15, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 16, 2023

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 16, 2023
@lance6716
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-14 08:58:00.209611678 +0000 UTC m=+162476.624215757: ☑️ agreed by D3Hunter.
  • 2023-06-15 02:18:14.114447862 +0000 UTC m=+224890.529051938: ☑️ agreed by lance6716.
  • 2023-06-15 02:37:05.347148155 +0000 UTC m=+226021.761752230: ✖️🔁 reset by GMHDBJD.
  • 2023-06-15 07:47:22.970848126 +0000 UTC m=+244639.385452200: ☑️ agreed by lance6716.
  • 2023-06-15 07:56:13.274637016 +0000 UTC m=+245169.689241095: ☑️ agreed by D3Hunter.
  • 2023-06-15 09:59:25.343965125 +0000 UTC m=+252561.758569205: ✖️🔁 reset by GMHDBJD.
  • 2023-06-16 06:18:14.710422687 +0000 UTC m=+325691.125026751: ☑️ agreed by D3Hunter.
  • 2023-06-16 06:42:09.188035708 +0000 UTC m=+327125.602639786: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 04eede1 into pingcap:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GMHDBJD @lance6716 @D3Hunter