test: fix data race in resouce control interceptor initialization #44789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/XS
|
/retest |
hawkingrei
approved these changes
Jun 19, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
nolouch
approved these changes
Jun 19, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
nolouch
approved these changes
Jun 19, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #44776
Problem Summary:
What is changed and how it works?
The change move the ResourceControlInterceptor from main into domain to avoid data race. In the previous implementation,
SetResourceControlInterceptoris run after dom is inited, so it's possible that session variable(tidb_enable_resource_control) initialization runs at the same time withSetResourceControlInterceptor.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.