Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copr: make cop request timeout a config parameter #45131

Merged
merged 8 commits into from
Jul 17, 2023
Merged

copr: make cop request timeout a config parameter #45131

merged 8 commits into from
Jul 17, 2023

Conversation

SpadeA-Tang
Copy link
Contributor

@SpadeA-Tang SpadeA-Tang commented Jul 3, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #45298
Ref tikv/tikv#15106

Problem Summary:
In dynamic region setting, region can be very large. Although copr request is based on buckets in the region, the bucket is not always even splitted properly, which makes the fix value of cop timeout 60s not appropriate for these cases.

What is changed and how it works?

Check List

Tests

  • Unit test

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@SpadeA-Tang
update
019a681 
Signed-off-by: Spade A <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2023
@tiprow
Copy link

tiprow bot commented Jul 3, 2023

Hi @SpadeA-Tang. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SpadeA-Tang
fmt
a3de99f 
Signed-off-by: Spade A <[email protected]>
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 3, 2023
MyonKeminta
MyonKeminta reviewed Jul 4, 2023
View reviewed changes
go.mod Outdated
@@ -304,5 +304,6 @@ replace (
github.com/dgrijalva/jwt-go => github.com/form3tech-oss/jwt-go v3.2.6-0.20210809144907-32ab6a8243d7+incompatible
github.com/go-ldap/ldap/v3 => github.com/YangKeao/ldap/v3 v3.4.5-0.20230421065457-369a3bab1117
github.com/pingcap/tidb/parser => ./parser
github.com/tikv/client-go/v2 => github.com/SpadeA-Tang/client-go/v2 v2.0.1-0.20230703094423-9f0b330b9fad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the url of the corresponding PR of client-go, and ask for reviews for that PR first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tikv/client-go#865

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023
@SpadeA-Tang
update
a7bc8f5 
Signed-off-by: Spade A <[email protected]>
@SpadeA-Tang
update client go
5b585c2 
Signed-off-by: Spade A <[email protected]>
@SpadeA-Tang
merge conflict
9339f23 
Signed-off-by: Spade A <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@SpadeA-Tang
update
0df67be 
Signed-off-by: Spade A <[email protected]>
@SpadeA-Tang
update
9d0b607 
Signed-off-by: Spade A <[email protected]>
@SpadeA-Tang
update
691288a 
Signed-off-by: Spade A <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 17, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, MyonKeminta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,cfzjywxk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-17 03:40:47.393522876 +0000 UTC m=+908139.163861574: ☑️ agreed by cfzjywxk.
  • 2023-07-17 05:07:14.131324484 +0000 UTC m=+913325.901663197: ☑️ agreed by MyonKeminta.

@ti-chi-bot ti-chi-bot bot merged commit 9a1ee39 into pingcap:master Jul 17, 2023
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make timeout of coprocessor request configurable
3 participants
@SpadeA-Tang @cfzjywxk @MyonKeminta