Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix column pruner will clear handleCols and lead filling _tidb_rowid when datasource's schema length is 0 for a pkIsHandled table #45217

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jul 6, 2023

What problem does this PR solve?

Issue Number: close #44579

Problem Summary:

What is changed and how it works?

step1: when column pruner #1 steps into datasource, it will keep column ‘a’ and clear handleCols in the case below
step2: ppd logical optimization will clear invalid condition count(a) = null, which is always false

step3: as is known to all, the last column pruner finds there is nothing required by datasource parent, it will clear all the schema columns existed now, and try to add a handle col (which cleared in step 1), therefore it adds a _tidb_rowid instead for a clustered table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
tiup playground v7.2.0 --tiflash=1 --db.binpath="/Users/arenatlx/go/src/github.com/pingcap/tidb/bin/tidb-server"
create table if not exists test.t1(a int(11) DEFAULT NULL, id int(11) NOT NULL, PRIMARY KEY (`id`) /*T![clustered_index] CLUSTERED */);
alter table test.t1 set tiflash replica 1;
use test; set tidb_enforce_mpp=on; set tidb_isolation_read_engines='tiflash';
explain select sum(1) as c from test.t1 having count(*)>1 or count(a)= null;
select sum(1) as c from test.t1 having count(*)>1 or count(a)= null;
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix column pruner will clear handleCols and leading filling _tidb_rowid for a pkIsHanle table

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2023
@tiprow
Copy link

tiprow bot commented Jul 6, 2023

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AilinKid AilinKid changed the title planner: fix column pruner will clear handleCols and leading filling _tidb_rowid for a pkIsHanle table planner: fix column pruner will clear handleCols and lead filling _tidb_rowid when datasource's schema length is 0 for a pkIsHandled table Jul 6, 2023
@AilinKid
Copy link
Contributor Author

AilinKid commented Jul 6, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Jul 6, 2023
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 10, 2023
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-10 04:56:53.660500343 +0000 UTC m=+307905.430839041: ☑️ agreed by elsa0520.
  • 2023-07-10 04:58:35.538033022 +0000 UTC m=+308007.308371734: ☑️ agreed by fixdb.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrysan, elsa0520, fixdb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 10, 2023
@AilinKid
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

@AilinKid: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #45257.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 11, 2023
…db_rowid when datasource's schema length is 0 for a pkIsHandled table (#45217) (#45257)

close #44579
@AilinKid AilinKid added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Aug 16, 2023
@AilinKid
Copy link
Contributor Author

/run cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #46134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: the column type sent by tidb to tiflash is inconsistent with the column type of the table schema
5 participants