Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix unstable test TestIndexDoubleReadClose #45244

Merged
merged 2 commits into from
Jul 10, 2023
Merged

*: fix unstable test TestIndexDoubleReadClose #45244

merged 2 commits into from
Jul 10, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 8, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #45245

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2023
@hawkingrei hawkingrei force-pushed the fix_TestIndexDoubleReadClose branch from c536c56 to 92d5fe7 Compare July 8, 2023 03:42
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 10, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-10 04:09:15.814910744 +0000 UTC m=+305047.585249449: ☑️ agreed by xhebox.
  • 2023-07-10 07:22:08.636811764 +0000 UTC m=+316620.407150473: ☑️ agreed by wshwsh12.

@ti-chi-bot ti-chi-bot bot merged commit 8d8ccba into pingcap:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@xhebox xhebox xhebox approved these changes

@Defined2014 Defined2014 Awaiting requested review from Defined2014

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unstable test TestIndexDoubleReadClose
3 participants
@hawkingrei @xhebox @wshwsh12