Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: fix pd http request using old address (#45680) #45737

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45680

What problem does this PR solve?

Issue Number: close #43436

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

lightning: fix the problem that lightning can work if all pd in its address is scaled

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.3 labels Aug 1, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 1, 2023
@lichunzhu
Copy link
Contributor

/run-br-integration-test

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.3@4220dfa). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.3     #45737   +/-   ##
================================================
  Coverage               ?   73.1974%           
================================================
  Files                  ?       1266           
  Lines                  ?     390727           
  Branches               ?          0           
================================================
  Hits                   ?     286002           
  Misses                 ?      86359           
  Partials               ?      18366           
Flag Coverage Δ
unit 73.1974% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <0.0000%> (?)
parser 85.0359% <0.0000%> (?)
br 51.9901% <0.0000%> (?)

@lichunzhu
Copy link
Contributor

/run-br-integration-test

@lichunzhu
Copy link
Contributor

/pull-br-integration-test

@lichunzhu
Copy link
Contributor

/retest

1 similar comment
@lichunzhu
Copy link
Contributor

/retest

@lichunzhu
Copy link
Contributor

/run-br-integration-test

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 3, 2023
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Aug 3, 2023

/retest

2 similar comments
@lichunzhu
Copy link
Contributor

/retest

@lichunzhu
Copy link
Contributor

/retest

@lichunzhu
Copy link
Contributor

/run-br-integration-test

@lichunzhu
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2023
@lichunzhu
Copy link
Contributor

/retest

@lichunzhu
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-03 12:00:35.05153484 +0000 UTC m=+359518.993883370: ☑️ agreed by GMHDBJD.
  • 2023-08-04 05:22:49.070625239 +0000 UTC m=+422053.012973770: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 203d839 into pingcap:release-7.3 Aug 4, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants