Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: modify headers of some source files in privilege (#46222) #46238

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46222

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. labels Aug 18, 2023
@CbcWestwolf
Copy link
Member

/retest
/lgtm
/cc TonsnakeLin

@ti-chi-bot ti-chi-bot bot requested a review from TonsnakeLin August 18, 2023 10:00
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 18, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-18 10:00:36.240980391 +0000 UTC m=+884400.789996378: ☑️ agreed by CbcWestwolf.
  • 2023-08-18 10:04:46.177201763 +0000 UTC m=+884650.726217747: ☑️ agreed by TonsnakeLin.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.2@9fd5f4a). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.2     #46238   +/-   ##
================================================
  Coverage               ?   73.2434%           
================================================
  Files                  ?       1239           
  Lines                  ?     385491           
  Branches               ?          0           
================================================
  Hits                   ?     282347           
  Misses                 ?      85066           
  Partials               ?      18078           
Flag Coverage Δ
unit 73.2434% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.8034% <0.0000%> (?)
parser 85.1954% <0.0000%> (?)
br 52.0212% <0.0000%> (?)

@CbcWestwolf
Copy link
Member

/lgtm

@CbcWestwolf
Copy link
Member

/approve

@CbcWestwolf
Copy link
Member

/lgtm

@CbcWestwolf
Copy link
Member

/approve

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 21, 2023
@CbcWestwolf
Copy link
Member

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, TonsnakeLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 511e399 into pingcap:release-7.2 Aug 21, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. type/cherry-pick-for-release-7.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants