Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import into: split real-tikv test #46299

Merged
merged 1 commit into from
Aug 22, 2023
Merged

import into: split real-tikv test #46299

merged 1 commit into from
Aug 22, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Aug 22, 2023

What problem does this PR solve?

Issue Number: ref #42930

Problem Summary:

What is changed and how it works?

currently, test in real-tikv-test is run in serial, if there're too many test in one directory, test will run slow and delay pr merge, or even timeout

so we add 3 importintotestX into real tikv test, we will split the test later, to avoid test timeout as we will add more test later.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 22, 2023
@tiprow
Copy link

tiprow bot commented Aug 22, 2023

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 22, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 22, 2023
@D3Hunter
Copy link
Contributor Author

cc @lance6716

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-22 02:59:34.101272848 +0000 UTC m=+1204738.650288820: ☑️ agreed by hawkingrei.
  • 2023-08-22 03:03:57.713571173 +0000 UTC m=+1205002.262587157: ☑️ agreed by lance6716.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #46299 (c43b2cd) into master (0c3bbc1) will decrease coverage by 0.6822%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46299        +/-   ##
================================================
- Coverage   73.3505%   72.6683%   -0.6822%     
================================================
  Files          1284       1305        +21     
  Lines        393242     399434      +6192     
================================================
+ Hits         288445     290262      +1817     
- Misses        86435      90743      +4308     
- Partials      18362      18429        +67     
Flag Coverage Δ
integration 25.6292% <ø> (?)
unit 73.3505% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0667% <ø> (ø)
br 47.8642% <ø> (-4.3597%) ⬇️

@ti-chi-bot ti-chi-bot bot merged commit ec60369 into master Aug 22, 2023
7 of 9 checks passed
@ti-chi-bot ti-chi-bot bot deleted the split-importinto-test branch August 22, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants