Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: not use the custom http client for gcs (#47026) #47056

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #47026

What problem does this PR solve?

Issue Number: close #47022

Problem Summary:
the custom http client for gcs should has the credential, but currently we don't provide it.

What is changed and how it works?

don't use the custom http client for gcs

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 18, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 18, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-18 07:56:02.38045305 +0000 UTC m=+504128.348041085: ☑️ agreed by YuJuncen.
  • 2023-09-18 08:01:26.470415859 +0000 UTC m=+504452.438003911: ☑️ agreed by 3pointer.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 18, 2023
@Leavrth
Copy link
Contributor

Leavrth commented Sep 18, 2023

/retest

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@774c4e7). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #47056   +/-   ##
================================================
  Coverage               ?   73.6742%           
================================================
  Files                  ?       1084           
  Lines                  ?     348305           
  Branches               ?          0           
================================================
  Hits                   ?     256611           
  Misses                 ?      75235           
  Partials               ?      16459           

@ti-chi-bot ti-chi-bot bot merged commit 71bcc44 into pingcap:release-6.5 Sep 18, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants