Shenli/show grants #473
Merged
Shenli/show grants #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
remove .testutil_test.go.swp .testutil_test.swp |
| // If a and b is exactly the same except the order, it returns true. | ||
| // In otherwise return false. | ||
| func CompareUnorderedStringSlice(a []string, b []string) bool { | ||
| if len(a) != len(b) { |
There was a problem hiding this comment.
I think sort and check may be better.
There was a problem hiding this comment.
May be. But no significant difference.
| . "github.com/pingcap/check" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
Remove those useless code.
|
LGTM |
| {nil, []string{}, false}, | ||
| } | ||
| for _, t := range tbl { | ||
| c.Assert(CompareUnorderedStringSlice(t.a, t.b), Equals, t.r) |
There was a problem hiding this comment.
Can use DeepEquals for this checking?
There was a problem hiding this comment.
Elements in a and b may have different order.
|
LGTM |
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
* parser: fix LONG syntax * address comment Co-Authored-By: leoppro <[email protected]> * resolve conflicts
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
* parser: fix LONG syntax * address comment Co-Authored-By: leoppro <[email protected]> * resolve conflicts
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
* parser: fix LONG syntax * address comment Co-Authored-By: leoppro <[email protected]> * resolve conflicts
nolouch
pushed a commit
to nolouch/tidb
that referenced
this pull request
Jul 13, 2023
Signed-off-by: AmoebaProtozoa <[email protected]>
rleungx
pushed a commit
to rleungx/tidb
that referenced
this pull request
Feb 26, 2024
* Adds a feature whitelist at planbuild stage (pingcap#304) * init Signed-off-by: David <[email protected]> * format errors Signed-off-by: David <[email protected]> * restrict information schema Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * bazel Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * disable datadir Signed-off-by: David <[email protected]> * add ttl check for create and alter table Signed-off-by: David <[email protected]> * create table ttl Signed-off-by: David <[email protected]> * address comments Signed-off-by: David <[email protected]> * update error doc Signed-off-by: David <[email protected]> * add the back to the error message Signed-off-by: David <[email protected]> * unblock 'SHOW CONFIG' for lightning Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: AmoebaProtozoa <[email protected]> # Conflicts: # ddl/BUILD.bazel # errno/errname.go # util/sem/sem.go * add test flag that can disable feature control (pingcap#328) Signed-off-by: David <[email protected]> Co-authored-by: iosmanthus <[email protected]> * Adds a feature whitelist at planbuild stage (pingcap#304) * init Signed-off-by: David <[email protected]> * format errors Signed-off-by: David <[email protected]> * restrict information schema Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * bazel Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * disable datadir Signed-off-by: David <[email protected]> * add ttl check for create and alter table Signed-off-by: David <[email protected]> * create table ttl Signed-off-by: David <[email protected]> * address comments Signed-off-by: David <[email protected]> * update error doc Signed-off-by: David <[email protected]> * add the back to the error message Signed-off-by: David <[email protected]> * unblock 'SHOW CONFIG' for lightning Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: AmoebaProtozoa <[email protected]> # Conflicts: # ddl/BUILD.bazel # errno/errname.go # util/sem/sem.go * disable validate password (pingcap#465) Signed-off-by: AmoebaProtozoa <[email protected]> * turn on validate password and set special char count to 0 (pingcap#464) * serverless version 16 Signed-off-by: AmoebaProtozoa <[email protected]> * fix typo in comments Signed-off-by: AmoebaProtozoa <[email protected]> * set special char to 0 Signed-off-by: AmoebaProtozoa <[email protected]> --------- Signed-off-by: AmoebaProtozoa <[email protected]> * disabling password validation (pingcap#467) * skip enabling password validation Signed-off-by: AmoebaProtozoa <[email protected]> * fix global variable Signed-off-by: AmoebaProtozoa <[email protected]> --------- Signed-off-by: AmoebaProtozoa <[email protected]> * allow edit waittimeout (pingcap#468) Signed-off-by: AmoebaProtozoa <[email protected]> * allow edit tidb-isolation-read-engines (pingcap#470) Signed-off-by: AmoebaProtozoa <[email protected]> * allow edit tidb_txn_mode (pingcap#471) Signed-off-by: AmoebaProtozoa <[email protected]> * allow edit tidb-cdc-write-source (pingcap#473) Signed-off-by: AmoebaProtozoa <[email protected]> * allow edit tidb_placement_mode (pingcap#474) Signed-off-by: AmoebaProtozoa <[email protected]> * please the checker Signed-off-by: AmoebaProtozoa <[email protected]> * sem enable now returns error on fail Signed-off-by: AmoebaProtozoa <[email protected]> * make check Signed-off-by: AmoebaProtozoa <[email protected]> --------- Signed-off-by: David <[email protected]> Signed-off-by: AmoebaProtozoa <[email protected]> Co-authored-by: iosmanthus <[email protected]> Co-authored-by: zzm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support show grants statement. See: https://dev.mysql.com/doc/refman/5.7/en/show-grants.html
We can start PhpMyAdmin with any error log now.