planner: in json explain make explaininfo an object instead of a string

[dveeden]

What problem does this PR solve?

Issue Number: close #39261

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The output of `EXPLAIN FORMAT=TIDB_JSON` was updated to have executeInfo as object instead of a string

[ti-chi-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tiprow]

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dveeden]

@fzzf678 @hawkingrei @time-and-fate could you let me know if you think this is the right way of doing this or if there is a better way?

[time-and-fate]

I'm OK with the current PR.
But I think the real problem will come up if we want to make all contents of executeInfo become JSON objects instead of strings, particularly the contents from (XXXRuntimeStats).String(). Looks like that part will be the hard part.

[ti-chi-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

@dveeden: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/build	f93684e	link	true	/test build
idc-jenkins-ci-tidb/check_dev_2	f93684e	link	true	/test check-dev2
idc-jenkins-ci-tidb/mysql-test	f93684e	link	true	/test mysql-test
idc-jenkins-ci-tidb/check_dev	f93684e	link	true	/test check-dev
pull-integration-ddl-test	f93684e	link	true	/test pull-integration-ddl-test
pull-mysql-client-test	f93684e	link	true	/test pull-mysql-client-test
idc-jenkins-ci-tidb/unit-test	f93684e	link	true	/test unit-test
pull-br-integration-test	f93684e	link	true	/test pull-br-integration-test
pull-lightning-integration-test	f93684e	link	true	/test pull-lightning-integration-test
pull-integration-e2e-test	f93684e	link	true	/test pull-integration-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ti-chi-bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qw4990 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS
• pkg/planner/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment