Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update tikv/client-go to fix batch-client send loop panic issue (#47716) #47745

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

crazycs520
Copy link
Contributor

cherry-pick #47716

What problem does this PR solve?

Issue Number: close #47691

related PR: tikv/client-go#1021

Problem Summary: update tikv/client-go to fix batch-client send loop panic issue

What is changed and how it works?

Check List

Tests

  • Unit test

  • Integration test
    Side effects

  • Performance regression: Consumes more CPU

  • Performance regression: Consumes more Memory

  • Breaking backward compatibility

Documentation

  • N/A

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2023
@tiprow
Copy link

tiprow bot commented Oct 18, 2023

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crazycs520
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 18, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 18, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-18 07:36:27.196007556 +0000 UTC m=+1815384.783117702: ☑️ agreed by cfzjywxk.
  • 2023-10-18 07:46:47.317884852 +0000 UTC m=+1816004.904994997: ☑️ agreed by you06.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 18, 2023
@crazycs520
Copy link
Contributor Author

/test build

@tiprow
Copy link

tiprow bot commented Oct 18, 2023

@crazycs520: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: crazycs520 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2023
@crazycs520
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 536545d into pingcap:release-7.1 Oct 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants