Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: improve information log information #47810

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #47809

Problem Summary: improve information log information

What is changed and how it works?

[2023/10/19 20:39:12.623 +08:00] [INFO] [domain.go:262] ["diff load InfoSchema success"] [currentSchemaVersion=50] [neededSchemaVersion=51] ["start time"=39.45µs] [gotSchemaVersion=51] [phyTblIDs="[]"] [actionTypes="[]"] [diffTypes="[\"create schema\"]"]

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 19, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 19, 2023
@tiprow
Copy link

tiprow bot commented Oct 19, 2023

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crazycs520
Copy link
Contributor Author

@xhebox @tangenta @cfzjywxk PTAL

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #47810 (eabbda3) into master (af7b32c) will increase coverage by 0.9231%.
Report is 181 commits behind head on master.
The diff coverage is 80.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47810        +/-   ##
================================================
+ Coverage   71.8707%   72.7938%   +0.9231%     
================================================
  Files          1399       1422        +23     
  Lines        405275     411653      +6378     
================================================
+ Hits         291274     299658      +8384     
+ Misses        94367      93148      -1219     
+ Partials      19634      18847       -787     
Flag Coverage Δ
integration 41.4719% <80.0000%> (?)
unit 71.8538% <80.0000%> (-0.0169%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6692% <ø> (-4.2612%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 19, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-19 13:03:19.337906069 +0000 UTC m=+1921396.925016211: ☑️ agreed by xhebox.
  • 2023-10-23 08:43:19.894897012 +0000 UTC m=+2251397.482007168: ☑️ agreed by cfzjywxk.

@xhebox
Copy link
Contributor

xhebox commented Nov 3, 2023

/approve

@xhebox
Copy link
Contributor

xhebox commented Nov 3, 2023

/cc @tangenta

@ti-chi-bot ti-chi-bot bot requested a review from tangenta November 3, 2023 08:36
Copy link

ti-chi-bot bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, tangenta, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 9, 2023
@ti-chi-bot ti-chi-bot bot merged commit 277169a into pingcap:master Nov 9, 2023
12 of 16 checks passed
crazycs520 added a commit to crazycs520/tidb that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log need to be improved
4 participants