-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add DataInDiskByChunks
to spill and restore data in chunks
#48160
Conversation
Hi @xzhangxian1008. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/cc @guo-shaoge |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48160 +/- ##
================================================
+ Coverage 71.1246% 72.3553% +1.2307%
================================================
Files 1365 1394 +29
Lines 404414 426944 +22530
================================================
+ Hits 287638 308917 +21279
- Misses 96830 98723 +1893
+ Partials 19946 19304 -642
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/cc @SeaRise |
okk, I will make a performane report. |
other LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guo-shaoge, SeaRise The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/unhold |
/hold |
/unhold |
/retest |
@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: ref #47733
Problem Summary:
What is changed and how it works?
Benchmark 1
Dataset: tpch10
tidb_mem_quota_query: 600Mib
sql: select l_orderkey from tpch10.lineitem group by l_orderkey having sum(l_quantity) > 300;
Results:
Benchmark2
Chunk num: 100
Row num in a chunk: 2000
Schema: 5 columns, with types: string, int64, string, int64, json
Results:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.