Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: put SortExec and TopNExec into different files #48569

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #47733

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 14, 2023
Copy link

tiprow bot commented Nov 14, 2023

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xzhangxian1008 xzhangxian1008 mentioned this pull request Nov 14, 2023
13 tasks
@xzhangxian1008
Copy link
Contributor Author

/cc @SeaRise @yibin87

@ti-chi-bot ti-chi-bot bot requested review from SeaRise and yibin87 November 14, 2023 02:16
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #48569 (1529a30) into master (50237bd) will increase coverage by 1.3823%.
Report is 1 commits behind head on master.
The diff coverage is 87.9194%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48569        +/-   ##
================================================
+ Coverage   71.4258%   72.8081%   +1.3823%     
================================================
  Files          1403       1428        +25     
  Lines        407207     413830      +6623     
================================================
+ Hits         290851     301302     +10451     
+ Misses        96405      93567      -2838     
+ Partials      19951      18961       -990     
Flag Coverage Δ
integration 43.4747% <72.4832%> (?)
unit 71.4162% <87.9194%> (-0.0096%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8187% <ø> (-4.2726%) ⬇️

@xzhangxian1008
Copy link
Contributor Author

/cc @XuHuaiyu

@ti-chi-bot ti-chi-bot bot requested a review from XuHuaiyu November 14, 2023 02:53
@xzhangxian1008
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Nov 14, 2023

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 14, 2023
Copy link

ti-chi-bot bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2023
Copy link

ti-chi-bot bot commented Nov 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-14 03:02:12.424773834 +0000 UTC m=+4131730.011883979: ☑️ agreed by XuHuaiyu.
  • 2023-11-14 03:18:45.230094966 +0000 UTC m=+4132722.817205106: ☑️ agreed by SeaRise.

@ti-chi-bot ti-chi-bot bot merged commit 361bdab into pingcap:master Nov 14, 2023
12 of 16 checks passed
@xzhangxian1008 xzhangxian1008 deleted the split-sort-topn branch November 14, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants