Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: add more test for tidb_merge_partition_stats_concurrency #48965

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 28, 2023

What problem does this PR solve?

Issue Number: close #48713

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #48965 (addcd5d) into master (ba608a9) will increase coverage by 1.6718%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48965        +/-   ##
================================================
+ Coverage   70.9881%   72.6600%   +1.6718%     
================================================
  Files          1368       1389        +21     
  Lines        404890     412703      +7813     
================================================
+ Hits         287424     299870     +12446     
+ Misses        97444      93896      -3548     
+ Partials      20022      18937      -1085     
Flag Coverage Δ
integration 43.6865% <ø> (?)
unit 70.9881% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.4613% <ø> (-4.6196%) ⬇️

Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 29, 2023
Copy link

ti-chi-bot bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [qw4990,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 29, 2023
Copy link

ti-chi-bot bot commented Nov 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-29 05:53:33.86430552 +0000 UTC m=+988442.529531715: ☑️ agreed by qw4990.
  • 2023-11-29 08:46:56.909509571 +0000 UTC m=+998845.574735747: ☑️ agreed by time-and-fate.

@ti-chi-bot ti-chi-bot bot merged commit f17ba4a into pingcap:master Nov 29, 2023
16 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #49013.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Feb 19, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #51158.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 19, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 19, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #51159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raise illegal bucket order while to merge global stats
4 participants