br: skip some warning during restore system schemas #49385

Leavrth · 2023-12-12T09:33:39Z

What problem does this PR solve?

Issue Number: ref #46527 Close #49394

Problem Summary:
some errors can be skipped.

What changed and how does it work?

skip the error

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Leavrth <[email protected]>

tiprow · 2023-12-12T09:33:58Z

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Leavrth · 2023-12-12T09:34:02Z

/test pull-br-integration-test

tiprow · 2023-12-12T09:34:25Z

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-12-12T09:51:39Z

Codecov Report

Merging #49385 (f7e9f60) into master (ba55c98) will increase coverage by 2.0848%.
Report is 95 commits behind head on master.
The diff coverage is 78.5714%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #49385        +/-   ##
================================================
+ Coverage   71.0537%   73.1385%   +2.0848%     
================================================
  Files          1368       1425        +57     
  Lines        401803     434549     +32746     
================================================
+ Hits         285496     317823     +32327     
- Misses        96449      96902       +453     
+ Partials      19858      19824        -34

Flag	Coverage Δ
integration	`47.9844% <78.5714%> (?)`
unit	`71.0553% <ø> (+0.0015%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9663% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`57.0517% <78.5714%> (+4.0929%)`	⬆️

Signed-off-by: Leavrth <[email protected]>

Leavrth · 2023-12-14T06:49:54Z

/test pull-br-integration-test

tiprow · 2023-12-14T06:50:18Z

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Leavrth <[email protected]>

Leavrth · 2023-12-14T07:38:54Z

/test pull-br-integration-test

tiprow · 2023-12-14T07:39:16Z

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Leavrth · 2023-12-14T09:14:42Z

error during merging temporary tables into system tables, table: tidb_mdl_view: [BR:Common:ErrUnknown]failed to execute REPLACE INTO mysql.tidb_mdl_view(job_id,db_name,table_name,query,session_id,txnstart,sql_digests) SELECT job_id,db_name,table_name,query,session_id,txnstart,sql_digests FROM __tidb_br_temporary_mysql.tidb_mdl_view ;: replace into view tidb_mdl_view is not supported now

Signed-off-by: Leavrth <[email protected]>

Leavrth · 2023-12-14T10:34:54Z

/test pull-br-integration-test

tiprow · 2023-12-14T10:35:16Z

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Leavrth · 2023-12-14T11:31:15Z

/retest

tiprow · 2023-12-14T11:31:40Z

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Leavrth <[email protected]>

Leavrth · 2023-12-15T07:24:55Z

/test pull-br-integration-test

tiprow · 2023-12-15T07:25:17Z

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Leavrth · 2023-12-15T09:37:43Z

/retest

tiprow · 2023-12-15T09:38:05Z

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Leavrth · 2023-12-18T01:28:55Z

/retest

tiprow · 2023-12-18T01:29:17Z

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-12-21T05:29:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~br/OWNERS~~ [3pointer,YuJuncen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-12-21T05:29:15Z

[LGTM Timeline notifier]

Timeline:

2023-12-12 09:35:53.283276551 +0000 UTC m=+348844.320503462: ☑️ agreed by 3pointer.
2023-12-21 05:29:14.353063482 +0000 UTC m=+1111645.390290409: ☑️ agreed by YuJuncen.

skip some warning during restore system schemas

999a917

Signed-off-by: Leavrth <[email protected]>

ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Dec 12, 2023

3pointer approved these changes Dec 12, 2023

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2023

ti-chi-bot bot added the do-not-merge/needs-triage-completed label Dec 13, 2023

skip some warning during restore system schemas

a9bd076

Signed-off-by: Leavrth <[email protected]>

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2023

Leavrth added 2 commits December 14, 2023 14:13

always flush privileges

89c4fcd

Signed-off-by: Leavrth <[email protected]>

make bazel happy

694bb46

Signed-off-by: Leavrth <[email protected]>

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Dec 14, 2023

skip grant table in binary mode

1ec7a10

Signed-off-by: Leavrth <[email protected]>

fix integration test

55b9168

Signed-off-by: Leavrth <[email protected]>

add the integration test case

f7e9f60

Signed-off-by: Leavrth <[email protected]>

YuJuncen approved these changes Dec 21, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 21, 2023

ti-chi-bot bot merged commit d2f3f36 into pingcap:master Dec 21, 2023
23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

br: skip some warning during restore system schemas #49385

br: skip some warning during restore system schemas #49385

Leavrth commented Dec 12, 2023 •

edited

Loading

tiprow bot commented Dec 12, 2023

Leavrth commented Dec 12, 2023

tiprow bot commented Dec 12, 2023

codecov bot commented Dec 12, 2023 •

edited

Loading

Leavrth commented Dec 14, 2023

tiprow bot commented Dec 14, 2023

Leavrth commented Dec 14, 2023

tiprow bot commented Dec 14, 2023

Leavrth commented Dec 14, 2023

Leavrth commented Dec 14, 2023

tiprow bot commented Dec 14, 2023

Leavrth commented Dec 14, 2023

tiprow bot commented Dec 14, 2023

Leavrth commented Dec 15, 2023

tiprow bot commented Dec 15, 2023

Leavrth commented Dec 15, 2023

tiprow bot commented Dec 15, 2023

Leavrth commented Dec 18, 2023

tiprow bot commented Dec 18, 2023

ti-chi-bot bot commented Dec 21, 2023

ti-chi-bot bot commented Dec 21, 2023

br: skip some warning during restore system schemas #49385

br: skip some warning during restore system schemas #49385

Conversation

Leavrth commented Dec 12, 2023 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Dec 12, 2023

Leavrth commented Dec 12, 2023

tiprow bot commented Dec 12, 2023

codecov bot commented Dec 12, 2023 • edited Loading

Codecov Report

Leavrth commented Dec 14, 2023

tiprow bot commented Dec 14, 2023

Leavrth commented Dec 14, 2023

tiprow bot commented Dec 14, 2023

Leavrth commented Dec 14, 2023

Leavrth commented Dec 14, 2023

tiprow bot commented Dec 14, 2023

Leavrth commented Dec 14, 2023

tiprow bot commented Dec 14, 2023

Leavrth commented Dec 15, 2023

tiprow bot commented Dec 15, 2023

Leavrth commented Dec 15, 2023

tiprow bot commented Dec 15, 2023

Leavrth commented Dec 18, 2023

tiprow bot commented Dec 18, 2023

ti-chi-bot bot commented Dec 21, 2023

ti-chi-bot bot commented Dec 21, 2023

[LGTM Timeline notifier]

Leavrth commented Dec 12, 2023 •

edited

Loading

codecov bot commented Dec 12, 2023 •

edited

Loading