Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: ignore NULL in handle binary literal (#49527) #49528

Merged
merged 2 commits into from
Dec 21, 2023
Merged

expression: ignore NULL in handle binary literal (#49527) #49528

merged 2 commits into from
Dec 21, 2023

Conversation

YangKeao
Copy link
Member

This is a manually cherry-pick of #49527

What problem does this PR solve?

Issue Number: close #49526

Problem Summary:

What changed and how does it work?

Ignore the TypeNull in HandleBinaryLiteral, as the castStringToString will actually do nothing for NULL (except changing the type).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Dec 17, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 17, 2023
windtalker
windtalker approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 17, 2023
@YangKeao YangKeao added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Dec 17, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [tangenta,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-17 10:06:09.584712997 +0000 UTC m=+782660.621939910: ☑️ agreed by windtalker.
  • 2023-12-17 10:54:35.323833842 +0000 UTC m=+785566.361060767: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 17, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@859fade). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #49528   +/-   ##
================================================
  Coverage               ?   73.6387%           
================================================
  Files                  ?       1087           
  Lines                  ?     349486           
  Branches               ?          0           
================================================
  Hits                   ?     257357           
  Misses                 ?      75603           
  Partials               ?      16526

@YangKeao YangKeao mentioned this pull request Dec 18, 2023
Closed
13 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit dfedcc7 into pingcap:release-6.5 Dec 21, 2023
10 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #49669.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 21, 2023
Closed
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 21, 2023
@ti-chi-bot
This is an automated cherry-pick of pingcap#49528
4d741d3 
Signed-off-by: ti-chi-bot <[email protected]>
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
@YangKeao
expression: ignore NULL in handle binary literal (pingcap#49527) (pin…
2dc4200 
…gcap#49528) (pingcap#34)

close pingcap#49526

Co-authored-by: YangKeao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YangKeao @ti-chi-bot @windtalker @tangenta