-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: fix data race in TestBootstrap (#39718) #49695
base: release-6.5
Are you sure you want to change the base?
session: fix data race in TestBootstrap (#39718) #49695
Conversation
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #49695 +/- ##
================================================
Coverage ? 77.2217%
================================================
Files ? 1098
Lines ? 381618
Branches ? 0
================================================
Hits ? 294692
Misses ? 70994
Partials ? 15932 |
/test unit-test |
@zimulala: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #39718
What problem does this PR solve?
Issue Number: close #39682
Problem Summary:
mustExec only open the executor, but not close it. We need close the recordSet by manual.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.