Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importinto: move post-process code from disttask pkg to importer pkg #49884

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #49883

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    do a basic import, make sure everything is ok. as this PR only moves code, will not add more test here.
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 28, 2023
@D3Hunter D3Hunter mentioned this pull request Dec 28, 2023
7 tasks
Copy link

tiprow bot commented Dec 28, 2023

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Merging #49884 (6a60697) into master (fbe232e) will increase coverage by 0.3049%.
Report is 5 commits behind head on master.
The diff coverage is 4.6242%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49884        +/-   ##
================================================
+ Coverage   70.9303%   71.2353%   +0.3049%     
================================================
  Files          1368       1430        +62     
  Lines        395402     416184     +20782     
================================================
+ Hits         280460     296470     +16010     
- Misses        95285     100921      +5636     
+ Partials      19657      18793       -864     
Flag Coverage Δ
integration 43.8957% <4.6242%> (?)
unit 70.9422% <ø> (+0.0118%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 46.8986% <ø> (-6.0609%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 28, 2023
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 28, 2023
Copy link

ti-chi-bot bot commented Dec 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-28 09:45:54.820816217 +0000 UTC m=+1731845.858043143: ☑️ agreed by lance6716.
  • 2023-12-28 10:00:40.260470597 +0000 UTC m=+1732731.297697527: ☑️ agreed by GMHDBJD.

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/test all

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Dec 29, 2023

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 84d9bc3 into pingcap:master Dec 29, 2023
17 checks passed
@D3Hunter D3Hunter deleted the refactor-import-into branch December 29, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants