importinto: import from select parser/planner part #49976

D3Hunter · 2024-01-02T09:06:35Z

What problem does this PR solve?

Issue Number: ref #49883

Problem Summary:

What changed and how does it work?

parser/planner part of import from select

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-01-02T09:06:51Z

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2024-01-02T09:20:52Z

Codecov Report

Merging #49976 (33c4ac5) into master (b4ba24b) will decrease coverage by 11.5438%.
Report is 32 commits behind head on master.
The diff coverage is 81.2807%.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #49976         +/-   ##
=================================================
- Coverage   79.3242%   67.7804%   -11.5438%     
=================================================
  Files          2445       2566        +121     
  Lines        673508     852411     +178903     
=================================================
+ Hits         534255     577768      +43513     
- Misses       117867     250640     +132773     
- Partials      21386      24003       +2617

Flag	Coverage Δ
integration	`37.7540% <53.3834%> (?)`
unit	`79.6775% <75.8620%> (+0.3532%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`73.6130% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`72.2233% <ø> (+3.7290%)`	⬆️

D3Hunter · 2024-01-02T11:24:22Z

/retest

tiprow · 2024-01-02T11:24:44Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2024-01-02T13:37:52Z

/retest

tiprow · 2024-01-02T13:38:14Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ywqzzy · 2024-01-03T03:10:30Z

pkg/executor/import_into.go

@@ -58,6 +58,7 @@ const unknownImportedRowCount = -1
 // ImportIntoExec represents a IMPORT INTO executor.


Import into and import from select

they're both IMPORT INTO statement

lance6716

pkg/parser reviewed

…t-parser

lance6716 · 2024-01-05T02:37:47Z

pkg/planner/core/planbuilder.go

+			return nil, ErrWrongValueCountOnRow.GenWithStackByArgs(1)
+		}
+		for _, cu := range ld.ColumnsAndUserVars {
+			// all fields must be column


Does IMPORT INTO without SELECT support user variables? If not we can find the error when parsing SQL.

maybe use ColumnNameList (need to add brackets) instead of ColumnNameOrUserVarListOptWithBrackets

lance6716 · 2024-01-05T02:43:13Z

pkg/planner/core/planbuilder.go

+		p.SelectPlan, _, err2 = DoOptimize(ctx, b.ctx, b.optFlag, selectPlan.(LogicalPlan))
+		if err2 != nil {
+			return nil, err2
+		}


Do we also want to return some friendly information to user? We can p.setSchemaAndNames

import from select works like insert into, not a background job, it will have a Message: rowsAffected like load data

but we can change it later after formal discuss

lance6716

rest lgtm

…t-parser

D3Hunter · 2024-01-05T07:09:58Z

/retest

tiprow · 2024-01-05T07:10:20Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…t-parser

D3Hunter · 2024-01-05T10:30:04Z

/retest

tiprow · 2024-01-05T10:30:52Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2024-01-05T10:49:27Z

/retest

tiprow · 2024-01-05T10:49:51Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2024-01-08T02:24:01Z

/retest

tiprow · 2024-01-08T02:24:23Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2024-01-08T03:06:44Z

[LGTM Timeline notifier]

Timeline:

2024-01-05 03:58:37.377904911 +0000 UTC m=+2402208.415131838: ☑️ agreed by lance6716.
2024-01-08 03:06:43.595889136 +0000 UTC m=+239793.180142823: ☑️ agreed by ywqzzy.

D3Hunter · 2024-01-08T03:29:49Z

/retest

tiprow · 2024-01-08T03:30:11Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2024-01-08T03:33:51Z

/ok-to-test

bb7133

LGTM

D3Hunter · 2024-01-08T06:11:12Z

/hold

wait 7.6 code freeze

D3Hunter · 2024-01-09T02:22:03Z

/unhold

D3Hunter · 2024-01-09T02:22:25Z

/approve

yudongusa

LGTM for the parser of new syntax

ti-chi-bot · 2024-01-09T02:55:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, D3Hunter, lance6716, tangenta, yudongusa, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [D3Hunter,bb7133,lance6716,tangenta]
~~pkg/parser/OWNERS~~ [D3Hunter,bb7133,tangenta,yudongusa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

D3Hunter · 2024-01-09T02:56:32Z

/retest

D3Hunter · 2024-01-09T04:15:41Z

/retest

change

2d5c7b3

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 2, 2024

D3Hunter mentioned this pull request Jan 2, 2024

import into from select #49883

Closed

7 tasks

ywqzzy reviewed Jan 3, 2024

View reviewed changes

D3Hunter requested a review from lance6716 January 4, 2024 11:53

lance6716 reviewed Jan 4, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/master' into import-from-selec…

444fc48

…t-parser

lance6716 reviewed Jan 5, 2024

View reviewed changes

lance6716 approved these changes Jan 5, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 5, 2024

D3Hunter added 2 commits January 5, 2024 13:57

fix comments

5774e74

Merge remote-tracking branch 'upstream/master' into import-from-selec…

6151a46

…t-parser

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024

Merge remote-tracking branch 'upstream/master' into import-from-selec…

33c4ac5

…t-parser

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2024

D3Hunter requested a review from GMHDBJD January 8, 2024 02:26

ywqzzy approved these changes Jan 8, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 8, 2024

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 8, 2024

bb7133 approved these changes Jan 8, 2024

View reviewed changes

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2024

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2024

tangenta approved these changes Jan 9, 2024

View reviewed changes

yudongusa approved these changes Jan 9, 2024

View reviewed changes

ti-chi-bot bot added the approved label Jan 9, 2024

ti-chi-bot bot merged commit edecaa6 into pingcap:master Jan 9, 2024
22 checks passed

D3Hunter deleted the import-from-select-parser branch January 9, 2024 05:58

		@@ -58,6 +58,7 @@ const unknownImportedRowCount = -1
		// ImportIntoExec represents a IMPORT INTO executor.

importinto: import from select parser/planner part #49976

importinto: import from select parser/planner part #49976

Conversation

D3Hunter commented Jan 2, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Jan 2, 2024

codecov bot commented Jan 2, 2024 • edited Loading

Codecov Report

D3Hunter commented Jan 2, 2024

tiprow bot commented Jan 2, 2024

D3Hunter commented Jan 2, 2024

tiprow bot commented Jan 2, 2024

ywqzzy Jan 3, 2024

Choose a reason for hiding this comment

D3Hunter Jan 3, 2024

Choose a reason for hiding this comment

lance6716 left a comment

Choose a reason for hiding this comment

lance6716 Jan 5, 2024

Choose a reason for hiding this comment

D3Hunter Jan 5, 2024

Choose a reason for hiding this comment

lance6716 Jan 5, 2024

Choose a reason for hiding this comment

lance6716 Jan 5, 2024

Choose a reason for hiding this comment

D3Hunter Jan 5, 2024

Choose a reason for hiding this comment

lance6716 left a comment

Choose a reason for hiding this comment

D3Hunter commented Jan 5, 2024

tiprow bot commented Jan 5, 2024

D3Hunter commented Jan 5, 2024

tiprow bot commented Jan 5, 2024

D3Hunter commented Jan 5, 2024

tiprow bot commented Jan 5, 2024

D3Hunter commented Jan 8, 2024

tiprow bot commented Jan 8, 2024

ti-chi-bot bot commented Jan 8, 2024

[LGTM Timeline notifier]

D3Hunter commented Jan 8, 2024

tiprow bot commented Jan 8, 2024

D3Hunter commented Jan 8, 2024

bb7133 left a comment

Choose a reason for hiding this comment

D3Hunter commented Jan 8, 2024

D3Hunter commented Jan 9, 2024

D3Hunter commented Jan 9, 2024

yudongusa left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Jan 9, 2024

D3Hunter commented Jan 9, 2024

D3Hunter commented Jan 9, 2024

codecov bot commented Jan 2, 2024 •

edited

Loading