test: fix unstable TestIndexChange and TestAlterAddConstraintStateChange3

[jiyfhust]

What problem does this PR solve?

Issue Number: close #50079, close #49825

Problem Summary:

To make the tests easy to reproduce:

--- a/pkg/ddl/job_table.go
+++ b/pkg/ddl/job_table.go
@@ -434,6 +434,9 @@ func (d *ddl) delivery2worker(wk *worker, pool *workerPool, job *model.Job) {
                                d.mu.hook.OnSchemaStateChanged(schemaVer)
                                d.mu.RUnlock()
                        }
+                       if job.SchemaState == model.StatePublic && job.State == model.JobStateSynced && job.TableName == "t" && job.Type == model.ActionCreateTable {
+                               time.Sleep(3000 * time.Millisecond)
+                       }
 
                        d.mu.RLock()
                        d.mu.hook.OnJobUpdated(job)

This pr:

1. Solve the unstable test.
2. Clean some useless code and make some enhencement.

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @jiyfhust. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jiyfhust]

/ok-to-test

[codecov]

Codecov Report

Merging #50144 (7681bfc) into master (4c7102c) will decrease coverage by 11.1741%.
Report is 54 commits behind head on master.
The diff coverage is 69.2307%.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #50144         +/-   ##
=================================================
- Coverage   79.3291%   68.1551%   -11.1741%     
=================================================
  Files          2447       2576        +129     
  Lines        673702     858640     +184938     
=================================================
+ Hits         534442     585207      +50765     
- Misses       117888     249678     +131790     
- Partials      21372      23755       +2383     

Flag	Coverage Δ
integration	38.5371% <ø> (?)
unit	80.0434% <69.2307%> (+0.7142%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	73.6130% <ø> (ø)
parser	∅ <ø> (∅)
br	72.3057% <ø> (+3.8084%)	⬆️

[hawkingrei]

/test all

[hawkingrei]

/test all

[tiprow]

@jiyfhust: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tiprow_fast_test	7681bfc	link	true	/test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Defined2014]

/run check-issue-triage-complete

[Defined2014]

/run-check-issue-triage-complete

[Defined2014]

/cc @tangenta @zimulala
PTAL

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-01-10 08:06:36.100549712 +0000 UTC m=+430585.684803401: ☑️ agreed by Defined2014.
• 2024-01-11 03:14:06.406696994 +0000 UTC m=+499435.990950680: ☑️ agreed by zimulala.

[Defined2014]

/test mysql-test

[tiprow]

@Defined2014: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Defined2014]

/retest