-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix leading hint cannot take effect in UNION ALL statements #50145
Conversation
Signed-off-by: Weizhen Wang <[email protected]>
0d88cd1
to
16a7d82
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50145 +/- ##
=================================================
- Coverage 79.3229% 67.2467% -12.0763%
=================================================
Files 2447 2569 +122
Lines 673700 842643 +168943
=================================================
+ Hits 534399 566650 +32251
- Misses 117932 252133 +134201
- Partials 21369 23860 +2491
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test check_dev |
@AilinKid: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, elsa0520 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -5468,24 +5468,19 @@ IndexMergeJoin 4.69 root inner join, inner:Projection, outer key:planner__core_ | |||
└─TableRowIDScan(Probe) 4.69 cop[tikv] table:t2 keep order:false, stats:pseudo | |||
explain format = 'brief' select /*+ leading(t2, t3@sel_2) */ * from t1 join t2 on t1.a=t2.a where t1.a in (select t3.a from t3); | |||
id estRows task access object operator info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR shouldn't change the result of this test
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
/cherry-pick release-7.6 |
In response to a cherrypick label: new pull request created to branch |
@ti-chi-bot: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.6 from head ti-chi-bot:cherry-pick-50145-to-release-7.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-50145-to-release-7.6."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #50067
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.