Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: remove useless field in temporaryIndexRecord #50202

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Jan 8, 2024

What problem does this PR solve?

Issue Number: close #50203

Problem Summary:
Found it when trying to close #49940 .

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jan 8, 2024
@jackysp jackysp requested a review from tangenta January 8, 2024 13:33
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.5307%. Comparing base (c21846e) to head (a5c80fa).
Report is 1742 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50202         +/-   ##
=================================================
- Coverage   70.0633%   55.5307%   -14.5327%     
=================================================
  Files          1436       1551        +115     
  Lines        419055     587003     +167948     
=================================================
+ Hits         293604     325967      +32363     
- Misses       105191     238383     +133192     
- Partials      20260      22653       +2393     
Flag Coverage Δ
integration 36.8421% <ø> (?)
unit 70.1338% <ø> (+0.0704%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 55.5973% <ø> (+5.9068%) ⬆️

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 8, 2024
Copy link

ti-chi-bot bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 9, 2024
Copy link

ti-chi-bot bot commented Jan 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-08 14:32:46.955775575 +0000 UTC m=+280956.540029264: ☑️ agreed by tangenta.
  • 2024-01-09 01:09:31.801139331 +0000 UTC m=+319161.385393018: ☑️ agreed by hawkingrei.

@jackysp
Copy link
Member Author

jackysp commented Jan 9, 2024

/retest

1 similar comment
@Defined2014
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 978436a into pingcap:master Jan 9, 2024
21 of 22 checks passed
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Aug 15, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #55449.

@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
5 participants