Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: refactor NewDistAggFunc for mpp agg aware of tipb's aggDesc execution mode #50961

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Feb 4, 2024

What problem does this PR solve?

Issue Number: close #50893

Problem Summary:

What changed and how does it work?

for this simple refactor work, the previous unit test is adequate, there is a concrete fix pull request next to fix explicit issues,

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2024
Copy link

tiprow bot commented Feb 4, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AilinKid AilinKid changed the title planner: refactor NewDistAggFunc for mpp agg aware of aggDesc's agg execution mode planner: refactor NewDistAggFunc for mpp agg aware of tipb's aggDesc execution mode Feb 4, 2024
.
Signed-off-by: AilinKid <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 4, 2024
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Merging #50961 (d347446) into master (732fa8c) will increase coverage by 0.5658%.
Report is 32 commits behind head on master.
The diff coverage is 75.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50961        +/-   ##
================================================
+ Coverage   72.2540%   72.8198%   +0.5657%     
================================================
  Files          1465       1467         +2     
  Lines        360889     439939     +79050     
================================================
+ Hits         260757     320363     +59606     
- Misses        80878      99508     +18630     
- Partials      19254      20068       +814     
Flag Coverage Δ
integration 49.2294% <72.2222%> (?)
unit 70.3203% <66.6666%> (-1.8193%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.1120% <ø> (-2.1513%) ⬇️
parser ∅ <ø> (∅)
br 51.2891% <ø> (+5.0081%) ⬆️

Copy link

ti-chi-bot bot commented Feb 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 4, 2024
Copy link

ti-chi-bot bot commented Feb 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-04 08:37:35.132364874 +0000 UTC m=+86780.699134764: ☑️ agreed by hawkingrei.
  • 2024-02-04 09:09:34.902591037 +0000 UTC m=+88700.469360928: ☑️ agreed by XuHuaiyu.

@AilinKid
Copy link
Contributor Author

AilinKid commented Feb 4, 2024

/test pull-mysql-client-test

Copy link

tiprow bot commented Feb 4, 2024

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-mysql-client-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AilinKid
Copy link
Contributor Author

AilinKid commented Feb 4, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 4, 2024
@AilinKid
Copy link
Contributor Author

AilinKid commented Feb 4, 2024

/test check-dev

Copy link

tiprow bot commented Feb 4, 2024

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tidb_parser_test
  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 38a87d0 into pingcap:master Feb 4, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: mpp-agg output wrong result for empty set in the mock handler of unistore
3 participants