Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execution: add default value logic for scalar final agg in mock mpp executor #50982

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Feb 5, 2024

What problem does this PR solve?

Issue Number: close #50893

Problem Summary:

What changed and how does it work?

previously mpp handler don't pay any attention to agg-pb‘s agg mode, which is to say they don't care about whether agg is finalAgg or partial ones. While for scalar finalAgg (when there is no groupKeys, itself is a scalar agg, which should be judged before running), default value logic filling is necessary, referred from current tidb execution and real tiflash logic. While for scalar partialAgg, filling default value logic is NOT necessary.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Feb 5, 2024
Copy link

ti-chi-bot bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ailinkid. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2024
Copy link

tiprow bot commented Feb 5, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.8514%. Comparing base (1621e0f) to head (b3741f5).
Report is 1633 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50982         +/-   ##
=================================================
- Coverage   70.5452%   55.8514%   -14.6938%     
=================================================
  Files          1466       1576        +110     
  Lines        434768     616408     +181640     
=================================================
+ Hits         306708     344273      +37565     
- Misses       108772     249383     +140611     
- Partials      19288      22752       +3464     
Flag Coverage Δ
integration 38.2950% <60.8695%> (?)
unit 71.6466% <86.9565%> (+1.2977%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.1120% <ø> (ø)
parser ∅ <ø> (∅)
br 51.5377% <ø> (+5.8344%) ⬆️

Copy link
Contributor Author

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @hawkingrei zhen

@ti-chi-bot ti-chi-bot bot requested a review from hawkingrei February 6, 2024 12:44
Copy link

ti-chi-bot bot commented Feb 6, 2024

@AilinKid: GitHub didn't allow me to request PR reviews from the following users: zhen.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @hawkingrei zhen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990 qw4990 requested a review from elsa0520 February 8, 2024 02:57
@AilinKid
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Feb 20, 2024

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2024
Copy link

ti-chi-bot bot commented Mar 29, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Apr 10, 2024

@AilinKid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test b3741f5 link true /test pull-br-integration-test
pull-lightning-integration-test b3741f5 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: mpp-agg output wrong result for empty set in the mock handler of unistore
1 participant