Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: remove evict slow store scheduler (#50776) #51043

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50776

What problem does this PR solve?

Issue Number: close #50566

Problem Summary:
one tikv has no leader and slow down br restore spee

What changed and how does it work?

remove evict-slow-store-scheduler when restore

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

image

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 7, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@75d0380). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #51043   +/-   ##
================================================
  Coverage               ?   72.1698%           
================================================
  Files                  ?       1403           
  Lines                  ?     409172           
  Branches               ?          0           
================================================
  Hits                   ?     295299           
  Misses                 ?      94161           
  Partials               ?      19712           
Flag Coverage Δ
unit 72.1698% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.2065% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 18, 2024
Copy link

ti-chi-bot bot commented Feb 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2024
Copy link

ti-chi-bot bot commented Feb 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-18 08:39:26.406575964 +0000 UTC m=+173655.154199075: ☑️ agreed by BornChanger.
  • 2024-02-18 08:40:15.443254329 +0000 UTC m=+173704.190877435: ☑️ agreed by Leavrth.

@Leavrth
Copy link
Contributor

Leavrth commented Feb 18, 2024

/retest

1 similar comment
@Leavrth
Copy link
Contributor

Leavrth commented Feb 18, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 73dff6a into pingcap:release-7.5 Feb 18, 2024
26 of 42 checks passed
@BornChanger
Copy link
Contributor

/type cherry-pick-release-7.1

Copy link

ti-chi-bot bot commented Feb 26, 2024

@BornChanger: The label(s) type/cherry-pick-release-7.1 cannot be applied, because the repository doesn't have them.

In response to this:

/type cherry-pick-release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor

/type cherry-pick-for-release-7.1

@ti-chi-bot ti-chi-bot bot added the type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. label Feb 26, 2024
@BornChanger
Copy link
Contributor

/type cherry-pick-for-release-6.5

@ti-chi-bot ti-chi-bot bot added the type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants