planner: fix dropping non-ScalarFunction when extractCol for memtable (#40935)

[ti-chi-bot]

This is an automated cherry-pick of #40935

Signed-off-by: Zhenchi [email protected]

Issue Number: close #40937

Problem Summary:

We can see extractLikePatternCol and extractTimeRange will keep non-ScalarFunctions by appending them to remained.

tidb/planner/core/memtable_predicate_extractor.go

Lines 432 to 437 in d6302c1

	for _, expr := range predicates {
	fn, ok := expr.(*expression.ScalarFunction)
	if !ok {
	remained = append(remained, expr)
	continue
	}

tidb/planner/core/memtable_predicate_extractor.go

Lines 265 to 270 in d6302c1

	for _, expr := range predicates {
	fn, ok := expr.(*expression.ScalarFunction)
	if !ok {
	remained = append(remained, expr)
	continue
	}

But not for extractCol. It seems a bug.

tidb/planner/core/memtable_predicate_extractor.go

Lines 210 to 214 in d6302c1

	for _, expr := range predicates {
	fn, ok := expr.(*expression.ScalarFunction)
	if !ok {
	continue
	}

What is changed and how it works?

Keep them the same.

Before this patch:

mysql [email protected]:information_schema> explain select * from `CLUSTER_HARDWARE` where `TYPE`;
+----------------+----------+------+------------------------+---------------+
| id             | estRows  | task | access object          | operator info |
+----------------+----------+------+------------------------+---------------+
| MemTableScan_5 | 10000.00 | root | table:CLUSTER_HARDWARE |               |
+----------------+----------+------+------------------------+---------------+

With this patch:

mysql [email protected]:information_schema> explain select * from `CLUSTER_HARDWARE` where `TYPE`;
+------------------+----------+------+------------------------+---------------+
| id               | estRows  | task | access object          | operator info |
+------------------+----------+------+------------------------+---------------+
| Selection_5      | 8000.00  | root |                        | Column#1      |
| └─MemTableScan_6 | 10000.00 | root | table:CLUSTER_HARDWARE |               |
+------------------+----------+------+------------------------+---------------+

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@f2f0a76). Click here to learn what that means.
The diff coverage is 0.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-6.5     #51180   +/-   ##
================================================
  Coverage               ?   73.6215%           
================================================
  Files                  ?       1095           
  Lines                  ?     350638           
  Branches               ?          0           
================================================
  Hits                   ?     258145           
  Misses                 ?      75913           
  Partials               ?      16580           

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-02-20 07:25:09.249528728 +0000 UTC m=+341997.997151839: ☑️ agreed by hawkingrei.
• 2024-02-20 07:27:47.114123593 +0000 UTC m=+342155.861746702: ☑️ agreed by AilinKid.