executor, expression: support Chunk in ProjectionExec #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
coocood
reviewed
Nov 21, 2017
| func EvalExprsToChunk(ctx context.Context, exprs []Expression, input, output *chunk.Chunk) error { | ||
| sc := ctx.GetSessionVars().StmtCtx | ||
| for rowID, length := 0, input.NumRows(); rowID < length; rowID++ { | ||
| for colID, expr := range exprs { |
There was a problem hiding this comment.
It would be more cache friendly If we move exprs range to outer for loop.
coocood
reviewed
Nov 21, 2017
expression/expression.go
Outdated
| } | ||
|
|
||
| func evalOneCell(sc *variable.StatementContext, expr Expression, input, output *chunk.Chunk, rowID, colID int) error { | ||
| switch fieldType, evalType := expr.GetType(), expr.GetType().EvalType(); evalType { |
There was a problem hiding this comment.
The EvalType is constant for every row, so we can loop all the rows under a certain eval type case.
|
LGTM |
XuHuaiyu
approved these changes
Nov 22, 2017
shenli
reviewed
Nov 22, 2017
| res, isNull, err := expr.EvalInt(input.GetRow(rowID), sc) | ||
| if err != nil { | ||
| return errors.Trace(err) | ||
| } else if isNull { |
There was a problem hiding this comment.
ok, I'll do it in the next pr
| } | ||
| case types.ETReal: | ||
| res, isNull, err := expr.EvalReal(input.GetRow(rowID), sc) | ||
| if err != nil { |
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify code, I haven't support vectorized expression evaluation here, to support it, we have to check whether there exists some special expressions, I'll do it in the near future.
Here is an example that we have to evaluate expressions row by row:
Main changes:
ProjectionExecsupport chunk and add implement functionNextChunk.EvalExprsToChunkin package expression to evaluate a list of expression based on an input Chunk and append all the result to an output Chunk. We can further improve it to evaluate output Chunk column by column, ie. support vectorized expression evaluation.newChunkto interfaceexecutor