expression: support vectorized execution of expressions #5184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Nov 22, 2017
expression/chunk_executor.go
Outdated
| func evalOneColumn(sc *stmtctx.StatementContext, expr Expression, input, output *chunk.Chunk, colID int) error { | ||
| switch fieldType, evalType := expr.GetType(), expr.GetType().EvalType(); evalType { | ||
| case types.ETInt: | ||
| for rowID, length := 0, input.NumRows(); rowID < length; rowID++ { |
There was a problem hiding this comment.
We can switch to assign a function to avoid loop in each case.
var execFunc func
switch {
case types.ETInt:
execFunc = executeToInt
}
for rowID, length := 0, input.NumRows(); rowID < length; rowID++ {
execFunc()
}
There was a problem hiding this comment.
I think it is already simple enough and there is no need to bring the latency of function addressing.
|
any benchmarks? |
alivxxx
reviewed
Nov 22, 2017
expression/chunk_executor.go
Outdated
| @@ -0,0 +1,278 @@ | |||
| // Copyright 2016 PingCAP, Inc. | |||
|
LGTM |
XuHuaiyu
reviewed
Nov 22, 2017
expression/chunk_executor.go
Outdated
| func evalOneColumn(sc *stmtctx.StatementContext, expr Expression, input, output *chunk.Chunk, colID int) error { | ||
| switch fieldType, evalType := expr.GetType(), expr.GetType().EvalType(); evalType { | ||
| case types.ETInt: | ||
| for rowID, length := 0, input.NumRows(); rowID < length; rowID++ { |
There was a problem hiding this comment.
s/ rowID < length/ err != nil && rowID < length
and extract the err check code
expression/chunk_executor.go
Outdated
| switch fieldType, evalType := expr.GetType(), expr.GetType().EvalType(); evalType { | ||
| case types.ETInt: | ||
| err := executeToInt(sc, expr, fieldType, input, output, rowID, colID) | ||
| if err != nil { |
There was a problem hiding this comment.
extract the error check code
|
/run-all-tests |
coocood
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.