-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txn: fix the warnings in pipelined dml #51867
Conversation
Hi @you06. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51867 +/- ##
=================================================
- Coverage 70.7413% 54.7341% -16.0072%
=================================================
Files 1477 1588 +111
Lines 438550 608399 +169849
=================================================
+ Hits 310236 333002 +22766
- Misses 108889 252166 +143277
- Partials 19425 23231 +3806
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -740,6 +741,7 @@ func TestConflictError(t *testing.T) { | |||
} | |||
|
|||
func TestRejectUnsupportedTables(t *testing.T) { | |||
t.Fail() // Does this package really tested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this PR: » go test ./tests/realtikvtest/pipelineddmltest --tags=intest
ok github.com/pingcap/tidb/tests/realtikvtest/pipelineddmltest 11.298s |
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
48bc2e6
to
beaba8f
Compare
Signed-off-by: you06 <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, ekexium The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #50215
Problem Summary:
Some tests failed need to be fixed. But CI doesn't test the pipelineddmltest package before, so need to merge PingCAP-QE/ci#2859 after this PR.
What changed and how does it work?
Check List
Tests
With this PR:
» go test ./tests/realtikvtest/pipelineddmltest --tags=intest ok github.com/pingcap/tidb/tests/realtikvtest/pipelineddmltest 11.298s
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.