Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: fix the warnings in pipelined dml #51867

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

you06
Copy link
Contributor

@you06 you06 commented Mar 18, 2024

What problem does this PR solve?

Issue Number: ref #50215

Problem Summary:

Some tests failed need to be fixed. But CI doesn't test the pipelineddmltest package before, so need to merge PingCAP-QE/ci#2859 after this PR.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

With this PR:

» go test ./tests/realtikvtest/pipelineddmltest --tags=intest
ok      github.com/pingcap/tidb/tests/realtikvtest/pipelineddmltest     11.298s

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2024
Copy link

tiprow bot commented Mar 18, 2024

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #51867 (bad0d33) into master (531e773) will decrease coverage by 16.0072%.
Report is 2 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51867         +/-   ##
=================================================
- Coverage   70.7413%   54.7341%   -16.0072%     
=================================================
  Files          1477       1588        +111     
  Lines        438550     608399     +169849     
=================================================
+ Hits         310236     333002      +22766     
- Misses       108889     252166     +143277     
- Partials      19425      23231       +3806     
Flag Coverage Δ
integration 36.6657% <0.0000%> (?)
unit 70.4630% <0.0000%> (-0.0807%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4718% <ø> (+5.6541%) ⬆️

@@ -740,6 +741,7 @@ func TestConflictError(t *testing.T) {
}

func TestRejectUnsupportedTables(t *testing.T) {
t.Fail() // Does this package really tested?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this package is not tested, need to figure out why.
image

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2024
@you06
Copy link
Contributor Author

you06 commented Mar 19, 2024

With this PR:

» go test ./tests/realtikvtest/pipelineddmltest --tags=intest
ok      github.com/pingcap/tidb/tests/realtikvtest/pipelineddmltest     11.298s

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 19, 2024
Signed-off-by: you06 <[email protected]>
Copy link

ti-chi-bot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 19, 2024
Copy link

ti-chi-bot bot commented Mar 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-19 04:19:20.203283505 +0000 UTC m=+1350387.225529892: ☑️ agreed by ekexium.
  • 2024-03-19 05:34:55.975215483 +0000 UTC m=+1354922.997461872: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot merged commit 9b6db9d into pingcap:master Mar 19, 2024
21 of 23 checks passed
you06 added a commit to you06/tidb that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants