Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix the stuck issue when use raw kv restore #51885

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Mar 19, 2024

What problem does this PR solve?

Issue Number: ref #50701

Problem Summary:
#51777 introduce a problem that raw kv restore will getting into stuck (catched by integration test). because the default concurrencyPerStore is 0.

What changed and how does it work?

we don't need to handle backpressure issue when doing a raw restore. so we add a flag to skip.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Mar 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 19, 2024
@3pointer
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. ok-to-test Indicates a PR is ready to be tested. labels Mar 19, 2024
Copy link

tiprow bot commented Mar 19, 2024

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3pointer
Copy link
Contributor Author

/test pull-br-integration-test

Copy link

tiprow bot commented Mar 19, 2024

@3pointer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3pointer 3pointer marked this pull request as ready for review March 19, 2024 05:59
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #51885 (6dbaf1a) into master (9b6db9d) will decrease coverage by 15.4535%.
Report is 3 commits behind head on master.
The diff coverage is 78.9473%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51885         +/-   ##
=================================================
- Coverage   70.7435%   55.2901%   -15.4535%     
=================================================
  Files          1477       1588        +111     
  Lines        438550     608497     +169947     
=================================================
+ Hits         310246     336439      +26193     
- Misses       108884     248503     +139619     
- Partials      19420      23555       +4135     
Flag Coverage Δ
integration 37.8851% <78.9473%> (?)
unit 70.4711% <0.0000%> (-0.0720%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 57.0714% <78.9473%> (+11.2428%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 19, 2024
Copy link

ti-chi-bot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 19, 2024
Copy link

ti-chi-bot bot commented Mar 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-19 08:28:18.835524936 +0000 UTC m=+1365325.857771323: ☑️ agreed by BornChanger.
  • 2024-03-19 08:36:07.09094229 +0000 UTC m=+1365794.113188675: ☑️ agreed by Leavrth.

@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 62fa6d1 into pingcap:master Mar 19, 2024
35 of 44 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #51919.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.0 ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants