-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: Enable checkpoint advancer to pause tasks lagged too large (#51441) #52105
br: Enable checkpoint advancer to pause tasks lagged too large (#51441) #52105
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
/cherry-pick-invite |
@RidRisR Please accept the invitation then you can push to the cherry-pick pull requests. |
726f77a
to
0c65091
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #52105 +/- ##
================================================
Coverage ? 73.6401%
================================================
Files ? 1095
Lines ? 351004
Branches ? 0
================================================
Hits ? 258480
Misses ? 75911
Partials ? 16613 |
@@ -17,6 +17,7 @@ const ( | |||
|
|||
DefaultConsistencyCheckTick = 5 | |||
DefaultTryAdvanceThreshold = 4 * time.Minute | |||
DefaultCheckPointLagLimit = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we may also need to pick the PR that enables this.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #51441
What problem does this PR solve?
Issue Number: close #50803
Problem Summary:
What changed and how does it work?
Now, a new option called
CheckPointLagLimit
is added to the advancer config. When it is set, advancer will check if the checkpoint is lagged too large on every tick. If so, advancer would send a warning to PD and unstall the task.PS: Theoretically, we need a resume signal when the task could be resumed. However, there is no channel to send this signal now. Maybe we will add it in the future.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.