Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: refactor pattern dir output memo related logic #52117

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Mar 26, 2024

What problem does this PR solve?

Issue Number: ref #51664

Problem Summary:

What changed and how does it work?

  • we use git mv file to keep the file's original git history, for better reference in the future.
  • separate the pattern related code output memo directory

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 26, 2024
Copy link

tiprow bot commented Mar 26, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: AilinKid <[email protected]>
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #52117 (2a23a1a) into master (8428e38) will decrease coverage by 15.9893%.
Report is 5 commits behind head on master.
The diff coverage is 93.8202%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52117         +/-   ##
=================================================
- Coverage   70.6615%   54.6722%   -15.9893%     
=================================================
  Files          1486       1599        +113     
  Lines        439481     609291     +169810     
=================================================
+ Hits         310544     333113      +22569     
- Misses       109404     253000     +143596     
- Partials      19533      23178       +3645     
Flag Coverage Δ
integration 36.7127% <92.1348%> (?)
unit 70.4405% <89.8876%> (-0.0231%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.5802% <ø> (+5.7871%) ⬆️

.
Signed-off-by: AilinKid <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 03:19:52.468482868 +0000 UTC m=+2038019.490729256: ☑️ agreed by hawkingrei.
  • 2024-03-27 03:22:24.723618103 +0000 UTC m=+2038171.745864491: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot merged commit 39d1575 into pingcap:master Mar 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants