Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: move logical optimizing trace logic out of core pkg #52161

Merged
merged 10 commits into from
Mar 28, 2024

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Mar 27, 2024

What problem does this PR solve?

Issue Number: ref #51664

Problem Summary:

What changed and how does it work?

target:

De-couple current rule framework from the logical optimizing trace framework, by splitting it into another pkg

  • just move the logical optimizing trace logic out of core pkg. (take it off optimizer.go)
  • git mv file from plan_stats.go to rule_collect_plan_stats with unified logical rule prefix.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2024
Copy link

tiprow bot commented Mar 27, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 27, 2024
.
Signed-off-by: AilinKid <[email protected]>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #52161 (ef616c4) into master (b942197) will decrease coverage by 17.6670%.
Report is 19 commits behind head on master.
The diff coverage is 98.1220%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52161         +/-   ##
=================================================
- Coverage   72.4092%   54.7423%   -17.6670%     
=================================================
  Files          1487       1603        +116     
  Lines        365652     610816     +245164     
=================================================
+ Hits         264766     334375      +69609     
- Misses        81332     253164     +171832     
- Partials      19554      23277       +3723     
Flag Coverage Δ
integration 36.7064% <93.4272%> (?)
unit 70.4683% <97.1831%> (-1.8333%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 51.5950% <ø> (+5.2657%) ⬆️

Copy link

ti-chi-bot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 11:55:08.210638039 +0000 UTC m=+2068935.232884426: ☑️ agreed by hawkingrei.
  • 2024-03-27 19:30:48.884194872 +0000 UTC m=+2096275.906441254: ☑️ agreed by winoros.

.
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 28, 2024
Signed-off-by: AilinKid <[email protected]>
@AilinKid
Copy link
Contributor Author

/test build

@AilinKid
Copy link
Contributor Author

/test check-dev2

Copy link

tiprow bot commented Mar 28, 2024

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Mar 28, 2024

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AilinKid
Copy link
Contributor Author

/test check-dev2

Copy link

tiprow bot commented Mar 28, 2024

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 927f3c6 into pingcap:master Mar 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants