-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: move logical optimizing trace logic out of core pkg #52161
planner: move logical optimizing trace logic out of core pkg #52161
Conversation
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52161 +/- ##
=================================================
- Coverage 72.4092% 54.7423% -17.6670%
=================================================
Files 1487 1603 +116
Lines 365652 610816 +245164
=================================================
+ Hits 264766 334375 +69609
- Misses 81332 253164 +171832
- Partials 19554 23277 +3723
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
/ok-to-test |
Signed-off-by: AilinKid <[email protected]>
/test build |
/test check-dev2 |
@AilinKid: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@AilinKid: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test check-dev2 |
@AilinKid: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: ref #51664
Problem Summary:
What changed and how does it work?
target:
De-couple current rule framework from the logical optimizing trace framework, by splitting it into another pkg
git mv
file fromplan_stats.go
torule_collect_plan_stats
with unified logical rule prefix.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.