Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: move physical opt and cost misc to util and split plan interface #52224

Merged
merged 19 commits into from
Apr 10, 2024

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Mar 29, 2024

What problem does this PR solve?

Issue Number: ref #51664

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 29, 2024
Copy link

tiprow bot commented Mar 29, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AilinKid AilinKid force-pushed the mv-physical-opt-and-cost-misc branch from a8855bb to 7935a94 Compare March 29, 2024 02:51
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 29, 2024
Copy link

ti-chi-bot bot commented Apr 3, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AilinKid AilinKid force-pushed the mv-physical-opt-and-cost-misc branch from 33cd363 to 6f091fa Compare April 7, 2024 08:16
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2024
MemoryUsage() int64
}
var _ Task = &copTask{}
var _ Task = &mppTask{}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we just move single rootTask struct out of this file temproary, because the task interface defined below has used the *rootTask.

in next several pull requests, all the task type here, will be moved out into one same task pkg place, dependent of core pkg

@AilinKid
Copy link
Contributor Author

AilinKid commented Apr 8, 2024

/retest

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Merging #52224 (120a939) into master (e540f0f) will increase coverage by 2.2506%.
Report is 3 commits behind head on master.
The diff coverage is 92.3387%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52224        +/-   ##
================================================
+ Coverage   72.2050%   74.4557%   +2.2506%     
================================================
  Files          1467       1470         +3     
  Lines        427020     427822       +802     
================================================
+ Hits         308330     318538     +10208     
+ Misses        99515      89452     -10063     
- Partials      19175      19832       +657     
Flag Coverage Δ
integration 48.8618% <85.2822%> (?)
unit 71.1120% <90.1209%> (+0.0167%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.9127% <ø> (+8.8104%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2024
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cost_misc.go and opt_tracer.go

@ti-chi-bot ti-chi-bot bot added sig/planner SIG: Planner and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 9, 2024
@AilinKid AilinKid force-pushed the mv-physical-opt-and-cost-misc branch from 09a9bb8 to 3c7dae8 Compare April 10, 2024 05:45
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
@AilinKid AilinKid force-pushed the mv-physical-opt-and-cost-misc branch from 3c7dae8 to 120a939 Compare April 10, 2024 09:11
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 10, 2024
@AilinKid AilinKid requested a review from winoros April 10, 2024 11:34
Copy link

ti-chi-bot bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 10, 2024
Copy link

ti-chi-bot bot commented Apr 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-09 13:18:03.570108788 +0000 UTC m=+968345.097649333: ☑️ agreed by winoros.
  • 2024-04-09 13:19:27.032243985 +0000 UTC m=+968428.559784531: ✖️🔁 reset by winoros.
  • 2024-04-10 09:48:17.138942819 +0000 UTC m=+1042158.666483368: ☑️ agreed by hawkingrei.
  • 2024-04-10 12:33:48.160950054 +0000 UTC m=+1052089.688490599: ☑️ agreed by winoros.

Copy link

ti-chi-bot bot commented Apr 10, 2024

@AilinKid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-lightning-integration-test 3c7dae8 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AilinKid
Copy link
Contributor Author

/test check-dev

Copy link

tiprow bot commented Apr 10, 2024

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants