-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk_snap_restore: remove checking store number (#51886) #52562
base: release-7.1
Are you sure you want to change the base?
disk_snap_restore: remove checking store number (#51886) #52562
Conversation
Signed-off-by: Yu Juncen <[email protected]> warn if store num not match Signed-off-by: Yu Juncen <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #52562 +/- ##
================================================
Coverage ? 73.4441%
================================================
Files ? 1211
Lines ? 379770
Branches ? 0
================================================
Hits ? 278919
Misses ? 83043
Partials ? 17808 |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #51886
warn if store num not match
What problem does this PR solve?
Issue Number: close #51957
Problem Summary:
It is unnecessary to check the store number in data restore phase -- since tidb-operator will help us to check it.
Now this check breaks a workaround for one store cannot unexpectedly bootstrap after restoring.
What changed and how does it work?
This PR removes the check to number of stores.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.