Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile to build tidb-server #526

Closed
wants to merge 3 commits into from
Closed

Add Dockerfile to build tidb-server #526

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 5, 2015

You must install docker first, then

docker build --rm -t tidb-server .

after build success, you may see images via

docker images

docker run -d --name tidb-server tidb-server

Signed-off-by: ZhiFeng Hu [email protected]

You must install docker first, then

docker build --rm -t tidb-server .

after build success, you may see images via

docker images

docker run -d --name tidb-server tidb-server

Signed-off-by: ZhiFeng Hu <[email protected]>
@ghost
Copy link
Author

ghost commented Nov 5, 2015

#522

Signed-off-by: ZhiFeng Hu <[email protected]>
@@ -0,0 +1,22 @@
FROM jeanblanchard/alpine-glibc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use golang 1.5 docker image directly?
See https://github.com/docker-library/docs/tree/master/golang

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image size should not too big.  using alpine glibc ,the image size just 53MB

通过 Android 版 Outlook 发送

On Thu, Nov 5, 2015 at 5:39 AM -0800, "siddontang" [email protected] wrote:

In Dockerfile:

@@ -0,0 +1,22 @@
+FROM jeanblanchard/alpine-glibc

why not use golang 1.5 docker image directly?

See https://github.com/docker-library/docs/tree/master/golang


Reply to this email directly or view it on GitHub.

The pre-built docker container will be available on

https://hub.docker.com/r/netroby/docker-tidb/

Only ~52.61MB

Signed-off-by: ZhiFeng Hu <[email protected]>
@siddontang
Copy link
Member

Hi @netroby , the docker environment should be the same as production environment, so we should use official golang image or popular ubuntu/debian/fedora, etc.
We don't care image size too much.

@ghost
Copy link
Author

ghost commented Nov 6, 2015

The container does not included Golang environment, it just build then generate binary executable tidb-server. then we can running the server inside container.

It's no need to include Golang environment at all, because the server ready for serve, no need recompile or include source code.
If we need recompile. The Dockfile can be used to compile it . generate new container.

@ngaut
Copy link
Member

ngaut commented Nov 6, 2015

Hi, @netroby :
Could you use golang as default image ?
It would be more convenient to run it, test it or even try to patch it. Thanks

@ghost
Copy link
Author

ghost commented Nov 6, 2015

Ok

@ghost ghost closed this Nov 6, 2015
coocood added a commit that referenced this pull request Nov 6, 2015
Dockerfile to build tidb, for #522, close #526
@ghost ghost deleted the pr/pr-dockerfile branch November 11, 2015 01:10
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
xhebox pushed a commit to xhebox/tidb that referenced this pull request Sep 28, 2021
xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021
rleungx pushed a commit to rleungx/tidb that referenced this pull request Feb 26, 2024
* default resource group (pingcap#245)

* default resource group

Signed-off-by: disksing <[email protected]>

* enable resource control

Signed-off-by: disksing <[email protected]>

* add comments

Signed-off-by: disksing <[email protected]>

* move DefaultResourceGroup to config

Signed-off-by: disksing <[email protected]>

---------

Signed-off-by: disksing <[email protected]>
Co-authored-by: zzm <[email protected]>

* Resource Control: fix segmentation violation when keyspace not set (pingcap#251)

* fix segmentation violation when setting up ru

Signed-off-by: David <[email protected]>

* only setup resource control when cluster id not empty

Signed-off-by: David <[email protected]>

---------

Signed-off-by: David <[email protected]>

* skip ur (pingcap#279)

Signed-off-by: ystaticy <[email protected]>

* disable resource group sql interface (pingcap#309)

Signed-off-by: disksing <[email protected]>

* *: update pd client and increase maxWaitDuration (pingcap#321)

Signed-off-by: disksing <[email protected]>

* update pd client and ru config (pingcap#325)

Signed-off-by: disksing <[email protected]>

* update max wait duration (pingcap#351)

Signed-off-by: disksing <[email protected]>

* update the pd client and client go (pingcap#419)

Signed-off-by: nolouch <[email protected]>

* update main

Signed-off-by: disksing <[email protected]>

---------

Signed-off-by: disksing <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: nolouch <[email protected]>
Co-authored-by: zzm <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: ystaticy <[email protected]>
Co-authored-by: ShuNing <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants