-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile to build tidb-server #526
Conversation
You must install docker first, then docker build --rm -t tidb-server . after build success, you may see images via docker images docker run -d --name tidb-server tidb-server Signed-off-by: ZhiFeng Hu <[email protected]>
Signed-off-by: ZhiFeng Hu <[email protected]>
@@ -0,0 +1,22 @@ | |||
FROM jeanblanchard/alpine-glibc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use golang 1.5 docker image directly?
See https://github.com/docker-library/docs/tree/master/golang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image size should not too big. using alpine glibc ,the image size just 53MB
通过 Android 版 Outlook 发送
On Thu, Nov 5, 2015 at 5:39 AM -0800, "siddontang" [email protected] wrote:
In Dockerfile:
@@ -0,0 +1,22 @@
+FROM jeanblanchard/alpine-glibc
why not use golang 1.5 docker image directly?
See https://github.com/docker-library/docs/tree/master/golang
—
Reply to this email directly or view it on GitHub.
The pre-built docker container will be available on https://hub.docker.com/r/netroby/docker-tidb/ Only ~52.61MB Signed-off-by: ZhiFeng Hu <[email protected]>
Hi @netroby , the docker environment should be the same as production environment, so we should use official golang image or popular ubuntu/debian/fedora, etc. |
The container does not included Golang environment, it just build then generate binary executable tidb-server. then we can running the server inside container. It's no need to include Golang environment at all, because the server ready for serve, no need recompile or include source code. |
Hi, @netroby : |
Ok |
Signed-off-by: you06 <[email protected]>
* default resource group (pingcap#245) * default resource group Signed-off-by: disksing <[email protected]> * enable resource control Signed-off-by: disksing <[email protected]> * add comments Signed-off-by: disksing <[email protected]> * move DefaultResourceGroup to config Signed-off-by: disksing <[email protected]> --------- Signed-off-by: disksing <[email protected]> Co-authored-by: zzm <[email protected]> * Resource Control: fix segmentation violation when keyspace not set (pingcap#251) * fix segmentation violation when setting up ru Signed-off-by: David <[email protected]> * only setup resource control when cluster id not empty Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]> * skip ur (pingcap#279) Signed-off-by: ystaticy <[email protected]> * disable resource group sql interface (pingcap#309) Signed-off-by: disksing <[email protected]> * *: update pd client and increase maxWaitDuration (pingcap#321) Signed-off-by: disksing <[email protected]> * update pd client and ru config (pingcap#325) Signed-off-by: disksing <[email protected]> * update max wait duration (pingcap#351) Signed-off-by: disksing <[email protected]> * update the pd client and client go (pingcap#419) Signed-off-by: nolouch <[email protected]> * update main Signed-off-by: disksing <[email protected]> --------- Signed-off-by: disksing <[email protected]> Signed-off-by: David <[email protected]> Signed-off-by: ystaticy <[email protected]> Signed-off-by: nolouch <[email protected]> Co-authored-by: zzm <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: ystaticy <[email protected]> Co-authored-by: ShuNing <[email protected]>
You must install docker first, then
docker build --rm -t tidb-server .
after build success, you may see images via
docker images
docker run -d --name tidb-server tidb-server
Signed-off-by: ZhiFeng Hu [email protected]