-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: remove internal pkg and move base code to certain place #52620
Conversation
Signed-off-by: AilinKid <[email protected]>
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52620 +/- ##
================================================
+ Coverage 72.3590% 74.3902% +2.0312%
================================================
Files 1470 1473 +3
Lines 427105 427412 +307
================================================
+ Hits 309049 317953 +8904
+ Misses 98798 89616 -9182
- Partials 19258 19843 +585
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest-required |
@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
/test check-dev2 |
/ok-to-test |
@AilinKid: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test fast_test_tiprow |
@AilinKid: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test fast_test_tiprow |
@AilinKid: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guo-shaoge, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #51664
Problem Summary:
What changed and how does it work?
there is some redundant pkg with test kit code and base plan structure definition inside, this pr just classify them to certain pkg, and reduce unnecessary pkg import
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.