Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: tools in scripts use fixed version to avoid incompatible updates #52629

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

purelind
Copy link
Contributor

@purelind purelind commented Apr 16, 2024

What problem does this PR solve?

Issue Number: ref #52473

Problem Summary:

What changed and how does it work?

  • installing third-party tools requires specifying the version to avoid incompatible changes as time goes by.
  • fix test utils load path

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/dumpling This is related to Dumpling of TiDB. labels Apr 16, 2024
Copy link

tiprow bot commented Apr 16, 2024

Hi @purelind. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor Author

/cc @GMHDBJD @okJiang

@ti-chi-bot ti-chi-bot bot requested review from GMHDBJD and okJiang April 16, 2024 03:33
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Merging #52629 (f55e002) into master (a0da76d) will increase coverage by 1.9640%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52629        +/-   ##
================================================
+ Coverage   72.4203%   74.3843%   +1.9639%     
================================================
  Files          1470       1470                
  Lines        427104     427320       +216     
================================================
+ Hits         309310     317859      +8549     
+ Misses        98619      89620      -8999     
- Partials      19175      19841       +666     
Flag Coverage Δ
integration 48.8912% <ø> (?)
unit 71.1809% <ø> (-0.1331%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.7325% <ø> (+8.6324%) ⬆️

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 17, 2024
Copy link

ti-chi-bot bot commented Apr 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-16 09:27:07.70634639 +0000 UTC m=+330246.817392840: ☑️ agreed by GMHDBJD.
  • 2024-04-17 04:53:30.772039987 +0000 UTC m=+400229.883086435: ☑️ agreed by Benjamin2037.

@purelind
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Apr 17, 2024

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 3b6a9db into pingcap:master Apr 17, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants