Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copIterator: return context error to avoid return incorrect result on context cancel/timeout #53489

Merged
merged 5 commits into from
May 23, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented May 22, 2024

What problem does this PR solve?

Issue Number: close #50089 #55500

Problem Summary:

What changed and how does it work?

always return context error when recvFromRespCh return closed=true

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 22, 2024
Copy link

tiprow bot commented May 22, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter D3Hunter requested a review from XuHuaiyu May 22, 2024 10:49
@D3Hunter D3Hunter changed the title copIterator: return context error to avoid return incorrect result copIterator: return context error to avoid return incorrect result on context cancel/timeout May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7152%. Comparing base (0afe54d) to head (4d53911).
Report is 727 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53489        +/-   ##
================================================
+ Coverage   72.5326%   74.7152%   +2.1826%     
================================================
  Files          1505       1505                
  Lines        429866     430465       +599     
================================================
+ Hits         311793     321623      +9830     
+ Misses        98774      89007      -9767     
- Partials      19299      19835       +536     
Flag Coverage Δ
integration 49.4006% <54.5454%> (?)
unit 71.4579% <72.7272%> (+0.0379%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4164% <ø> (+9.0429%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 22, 2024
@D3Hunter D3Hunter requested a review from lance6716 May 23, 2024 02:18
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 23, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 23, 2024
Copy link

ti-chi-bot bot commented May 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-23 03:27:48.375031511 +0000 UTC m=+2315022.132167085: ☑️ agreed by tiancaiamao.
  • 2024-05-23 06:09:31.732759772 +0000 UTC m=+2324725.489895333: ☑️ agreed by wshwsh12.

Copy link

tiprow bot commented May 23, 2024

@D3Hunter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 4d53911 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, tiancaiamao, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 23, 2024
@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented May 23, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 3004c07 into pingcap:master May 23, 2024
22 of 23 checks passed
@D3Hunter D3Hunter deleted the fix50089 branch May 23, 2024 10:18
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 27, 2024
@crazycs520 crazycs520 added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Aug 19, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #55499.

crazycs520 added a commit to crazycs520/tidb that referenced this pull request Aug 19, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Aug 19, 2024
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Aug 26, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #55636.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #55637.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #55638.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 26, 2024
crazycs520 added a commit to ti-chi-bot/tidb that referenced this pull request Aug 26, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Aug 26, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Sep 14, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Sep 14, 2024
crazycs520 added a commit to ti-chi-bot/tidb that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query returns incorrect result when context done in the middle
6 participants