-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: fix issue of information schema cache miss cause by schema version gap (#53445) #53583
infoschema: fix issue of information schema cache miss cause by schema version gap (#53445) #53583
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
This reverts commit 0771279.
…formation schema cache (pingcap#48284) close pingcap#48285 Signed-off-by: crazycs520 <[email protected]>
…a version gap (pingcap#53445) close pingcap#53428 Signed-off-by: crazycs520 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #53583 +/- ##
================================================
Coverage ? 73.6385%
================================================
Files ? 1096
Lines ? 351665
Branches ? 0
================================================
Hits ? 258961
Misses ? 76065
Partials ? 16639 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
…a version gap (pingcap#53445) (pingcap#53583) (pingcap#97) close pingcap#53428 Co-authored-by: Ti Chi Robot <[email protected]>
This is an automated cherry-pick of #53445
What problem does this PR solve?
Issue Number: close #53428
Problem Summary: fix issue of information schema cache miss cause by schema version gap
What changed and how does it work?
before this PR
When DDL has empty schema version, will cause cache miss, then stale-read query need to load snapshot schema from TiKV.
This PR
When DDL has empty schema version, this PR won't have schema cache miss, then won't cause many load snapshot schema operation.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.